Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize updates in NEProfileRepository #742

Merged
merged 7 commits into from
Oct 19, 2024
Merged

Optimize updates in NEProfileRepository #742

merged 7 commits into from
Oct 19, 2024

Conversation

keeshux
Copy link
Member

@keeshux keeshux commented Oct 19, 2024

Currently, NEProfileRepository decodes profiles from ALL NE managers on any update. This is undesirable considering that:

  • Profiles are only added by the app
  • Externally, profiles can only be removed

Therefore:

  • Observe the initial managers to decode the initial profiles from them
  • Publish values manually on save/delete (to ProfileManager eventually)
  • Observe the subsequent updates for when a profile is removed externally, i.e. its ID doesn't appear in managers

Fixes #741

@keeshux keeshux self-assigned this Oct 19, 2024
@keeshux keeshux added the refactoring Improves software architecture label Oct 19, 2024
@keeshux keeshux added this to the 3.0.0 / 5. Release milestone Oct 19, 2024
@keeshux keeshux merged commit 2155fe1 into master Oct 19, 2024
1 check passed
@keeshux keeshux deleted the refactoring/reduce-ne-profile-updates branch October 19, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@keeshux keeshux

Labels
refactoring Improves software architecture
Projects
2024 Q1-Q4 Passepartout v3
Status: Done
Milestone
3.0.0 / 5. Release
Development

Successfully merging this pull request may close these issues.

Observing NETunnelManagerRepository.managersPublisher might be too much
1 participant
@keeshux