Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update README initialize code block #167

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

vanessa-passage
Copy link
Contributor

What's New?

Screenshots (if appropriate):

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have manually tested my code thoroughly
  • I have added/updated inline documentation for public facing interfaces if relevant
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing integration and unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

@@ -53,8 +53,7 @@ require 'passageidentity'
PassageClient =
Passage::Client.new(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since the other SDKs show setting it from env var:

PassageClient = Passage::Client.new(
  app_id: ENV.fetch('PASSAGE_APP_ID'),
  api_key: ENV.fetch('PASSAGE_API_KEY')
)

@vanessa-passage vanessa-passage merged commit 01e5863 into main Jan 14, 2025
6 checks passed
@vanessa-passage vanessa-passage deleted the PSG-5727-passage-ruby-update-readme-content branch January 14, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants