fix: jwt validation correctly compares the aud with both app id and auth origin #147
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's New?
There was a bug where the
validate_jwt
method was not using the correct auth origin value when verifying the jwt audience.The jwt would still pass verification if it was the new structure, since it also includes the app id in the audience array. But it would compare a
nil
auth origin to the jwt's real auth origin.To repro:
Change the expected audience to only check for
@auth_origin
and run the auth tests. they should error, statingwhere
nil
is supposed to be the value of@auth_origin
Screenshots (if appropriate):
Type of change
Checklist:
Additional context