Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use keywords for revoke_device #119

Merged
merged 1 commit into from
Dec 11, 2024
Merged

fix: use keywords for revoke_device #119

merged 1 commit into from
Dec 11, 2024

Conversation

bertrmz
Copy link
Contributor

@bertrmz bertrmz commented Dec 11, 2024

BEGIN_COMMIT_OVERRIDE
chore: use keywords for revoke_device
END_COMMIT_OVERRIDE

What's New?

This addresses the following error:

wrong number of arguments (given 2, expected 0; required keywords: user_id, device_id)
/lib/passageidentity/user_api.rb:135:in `revoke_device'
/lib/passageidentity/user_api.rb:150:in `delete_device'

Screenshots (if appropriate):

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have manually tested my code thoroughly
  • I have added/updated inline documentation for public facing interfaces if relevant
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing integration and unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

@bertrmz bertrmz requested review from vanessa-passage and a team December 11, 2024 19:33
@bertrmz bertrmz merged commit afb787a into main Dec 11, 2024
6 checks passed
@bertrmz bertrmz deleted the fix-revoke-device branch December 11, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants