Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump faraday version - Major release #115

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

vanessa-passage
Copy link
Contributor

@vanessa-passage vanessa-passage commented Dec 6, 2024

What's New?

Increased the faraday dependancy.

Ruby and activesupport need to be increased but those are breaking changes.

Let me know if there is anything else in the tool chain I've missed.

Screenshots (if appropriate):

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have manually tested my code thoroughly
  • I have added/updated inline documentation for public facing interfaces if relevant
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing integration and unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

@vanessa-passage vanessa-passage changed the title Psg 4875 milestone 7 passage ruby update tool chain feat: bump faraday version Dec 6, 2024
@vanessa-passage
Copy link
Contributor Author

I can't get this to fail locally. Looking into the error.

@ctran88
Copy link
Contributor

ctran88 commented Dec 6, 2024

I can't get this to fail locally. Looking into the error.

could be because CI is running in 3.1 and devcontainer is set to 3.3 (which prob should be set back to 3.1)

@vanessa-passage
Copy link
Contributor Author

@ctran88 is right. This makes the work a breaking changes. I will leave this PR and revisit when I update the Ruby version and release with the major release.

@vanessa-passage vanessa-passage changed the title feat: bump faraday version feat: bump faraday version - Major release Dec 9, 2024
Copy link

sonarqubecloud bot commented Dec 9, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants