Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: fix linting and formatting errors #101

Conversation

vanessa-passage
Copy link
Contributor

@vanessa-passage vanessa-passage commented Nov 6, 2024

What's New?

Formatting and linting. In the future, it will only be run on files that are not generated.

Screenshots (if appropriate):

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have manually tested my code thoroughly
  • I have added/updated inline documentation for public facing interfaces if relevant
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing integration and unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

@vanessa-passage vanessa-passage changed the title Configure prettier [WIP} Configure prettier Nov 6, 2024
@vanessa-passage vanessa-passage changed the title [WIP} Configure prettier [WIP] style: fix linting and formatting errors Nov 6, 2024
@vanessa-passage vanessa-passage changed the title [WIP] style: fix linting and formatting errors style: fix linting and formatting errors Nov 11, 2024
Copy link
Contributor

@ctran88 ctran88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all of the changes under /docs can be dropped since they were supposed to be excluded from the linter/formatter anyways and a new codegen will generate a ton of diffs in the next PR.

this includes the lib/openapi_client file as well

.rubocop.yml Outdated Show resolved Hide resolved
.rubocop.yml Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
lib/passageidentity/auth.rb Outdated Show resolved Hide resolved
passageidentity.gemspec Show resolved Hide resolved
lib/passageidentity/client.rb Outdated Show resolved Hide resolved
lib/passageidentity/auth.rb Outdated Show resolved Hide resolved
lib/passageidentity/error.rb Outdated Show resolved Hide resolved
lib/passageidentity/user_api.rb Show resolved Hide resolved
@ctran88 ctran88 mentioned this pull request Nov 14, 2024
12 tasks
@vanessa-passage
Copy link
Contributor Author

@ctran88 This should be ready for final review.

@vanessa-passage vanessa-passage merged commit d6b8602 into main Nov 19, 2024
5 checks passed
@vanessa-passage vanessa-passage deleted the PSG-5198-milestone-7-passage-ruby-address-linter-and-formatter-errors-warnings branch November 19, 2024 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants