feat: rename get_by_identifier kwarg

lib/passageidentity/user.rb

@@ -28,11 +28,11 @@ def get(user_id:)
       end
     end
 
-    def get_by_identifier(user_identifier:)
-      raise ArgumentError, 'identifier is required.' unless user_identifier && !user_identifier.empty?
+    def get_by_identifier(identifier:)
+      raise ArgumentError, 'identifier is required.' unless identifier && !identifier.empty?
 
       begin
-        req_opts = set_get_by_identifier_query_params(identifier: user_identifier)
+        req_opts = set_get_by_identifier_query_params(identifier: identifier)
         response = @user_client.list_paginated_users(@app_id, req_opts)
       rescue Faraday::Error => e
         raise PassageError.new(

tests/user_test.rb

@@ -45,7 +45,7 @@ def test_get_user_by_identifier
     user = PassageClient.user.get(user_id: @test_user.id)
     assert_equal @test_user.id, user.id
 
-    user_by_identifier = PassageClient.user.get_by_identifier(user_identifier: @test_user.email)
+    user_by_identifier = PassageClient.user.get_by_identifier(identifier: @test_user.email)
     assert_equal @test_user.id, user_by_identifier.id
 
     assert_equal user, user_by_identifier
@@ -55,7 +55,7 @@ def test_get_user_by_identifier_upper_case
     user = PassageClient.user.get(user_id: @test_user.id)
     assert_equal @test_user.id, user.id
 
-    user_by_identifier = PassageClient.user.get_by_identifier(user_identifier: @test_user.email.upcase)
+    user_by_identifier = PassageClient.user.get_by_identifier(identifier: @test_user.email.upcase)
     assert_equal @test_user.id, user_by_identifier.id
 
     assert_equal user, user_by_identifier
@@ -70,7 +70,7 @@ def test_get_user_by_identifier_phone
     user = PassageClient.user.get(user_id: create_user.id)
     assert_equal create_user.id, user.id
 
-    user_by_identifier = PassageClient.user.get_by_identifier(user_identifier: phone)
+    user_by_identifier = PassageClient.user.get_by_identifier(identifier: phone)
     assert_equal create_user.id, user_by_identifier.id
 
     assert_equal user, user_by_identifier
@@ -81,7 +81,7 @@ def test_invalid_get_by_identifier
     assert_equal @test_user.id, user.id
 
     assert_raise Passage::PassageError do
-      PassageClient.user.get_by_identifier(user_identifier: '[email protected]')
+      PassageClient.user.get_by_identifier(identifier: '[email protected]')
     end
   end