Skip to content

Commit

Permalink
style: disable single lines
Browse files Browse the repository at this point in the history
  • Loading branch information
vanessa-passage committed Nov 14, 2024
1 parent 0df970a commit 5a15e55
Show file tree
Hide file tree
Showing 6 changed files with 39 additions and 26 deletions.
3 changes: 3 additions & 0 deletions .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,7 @@ Metrics/ClassLength:

Layout/LineLength:
Max: 120

Metrics/MethodLength:
Max: 50

4 changes: 3 additions & 1 deletion lib/passageidentity/auth.rb
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
module Passage
# The Passage::Auth class provides methods for authenticating requests and tokens
class Auth
# rubocop:disable Metrics/AbcSize
def initialize(app_id, auth_strategy)
@app_cache = {}
@app_id = app_id
Expand Down Expand Up @@ -136,13 +137,14 @@ def revoke_user_refresh_tokens(user_id)
end

private

def get_cache(key)
@app_cache[key]
end

def set_cache(key, value)
@app_cache[key] = value
end
# rubocop:enable Metrics/AbcSize
end
end
4 changes: 4 additions & 0 deletions lib/passageidentity/client.rb
Original file line number Diff line number Diff line change
Expand Up @@ -36,13 +36,16 @@ def initialize(app_id:, api_key: '', auth_strategy: COOKIE_STRATEGY)
@user = Passage::UserAPI.new(@app_id, @api_key)
end

# rubocop:disable Naming/AccessorMethodName
def get_app
client = OpenapiClient::AppsApi.new
client.get_app(@app_id).app
rescue StandardError => e
raise e
end
# rubocop:enable Naming/AccessorMethodName

# rubocop:disable Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity, Metrics/ParameterLists, Metrics/AbcSize
def create_magic_link(
user_id: '',
email: '',
Expand Down Expand Up @@ -99,5 +102,6 @@ def create_magic_link(
)
end
end
# rubocop:enable Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity, Metrics/ParameterLists, Metrics/AbcSize
end
end
2 changes: 2 additions & 0 deletions lib/passageidentity/user_api.rb
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
module Passage
# The UserAPI class provides methods for interacting with Passage Users
class UserAPI
# rubocop:disable Metrics/AbcSize
# This class will require an API key
def initialize(app_id, api_key)
@app_id = app_id
Expand Down Expand Up @@ -256,5 +257,6 @@ def device_exists?(device_id)

raise PassageError.new(message: 'must supply a valid device_id')
end
# rubocop:enable Metrics/AbcSize
end
end
2 changes: 2 additions & 0 deletions passageidentity.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,10 @@ Gem::Specification.new do |s|
s.name = 'passageidentity'
s.version = Passage::VERSION
s.summary = 'Passage Passkey Complete SDK'
# rubocop:disable Layout/LineLength
s.description =
'Passkey Complete for Ruby - Integrate into your Ruby API or service to enable a completely passwordless standalone auth solution with Passage by 1Password.'
# rubocop:enable Layout/LineLength
s.authors = ['Passage by 1Password']
s.email = '[email protected]'
s.files = ['lib/passageidentity.rb']
Expand Down
50 changes: 25 additions & 25 deletions tests/user_api_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ class TestUserAPI < Test::Unit::TestCase
Passage::Client.new(app_id: ENV['APP_ID'], api_key: ENV['API_KEY'])

def setup
$global_test_user =
@test_user =
PassageClient.user.create(
email: '[email protected]',
user_metadata: {
Expand All @@ -37,91 +37,91 @@ def test_create_delete_user
end

def test_get_user
user = PassageClient.user.get(user_id: $global_test_user.id)
assert_equal $global_test_user.id, user.id
user = PassageClient.user.get(user_id: @test_user.id)
assert_equal @test_user.id, user.id
end

def test_get_user_by_identifier
user = PassageClient.user.get(user_id: $global_test_user.id)
assert_equal $global_test_user.id, user.id
user = PassageClient.user.get(user_id: @test_user.id)
assert_equal @test_user.id, user.id

user_by_identifier = PassageClient.user.get_by_identifier(user_identifier: $global_test_user.email)
assert_equal $global_test_user.id, user_by_identifier.id
user_by_identifier = PassageClient.user.get_by_identifier(user_identifier: @test_user.email)
assert_equal @test_user.id, user_by_identifier.id

assert_equal user, user_by_identifier
end

def test_get_user_by_identifier_upper_case
user = PassageClient.user.get(user_id: $global_test_user.id)
assert_equal $global_test_user.id, user.id
user = PassageClient.user.get(user_id: @test_user.id)
assert_equal @test_user.id, user.id

user_by_identifier = PassageClient.user.get_by_identifier(user_identifier: $global_test_user.email.upcase)
assert_equal $global_test_user.id, user_by_identifier.id
user_by_identifier = PassageClient.user.get_by_identifier(user_identifier: @test_user.email.upcase)
assert_equal @test_user.id, user_by_identifier.id

assert_equal user, user_by_identifier
end

def test_get_user_by_identifier_phone
$phone = '+15005550007'
phone = '+15005550007'
create_user = PassageClient.user.create(
phone: $phone
phone: phone
)
user = PassageClient.user.get(user_id: create_user.id)
assert_equal create_user.id, user.id

user_by_identifier = PassageClient.user.get_by_identifier(user_identifier: $phone)
user_by_identifier = PassageClient.user.get_by_identifier(user_identifier: phone)
assert_equal create_user.id, user_by_identifier.id

assert_equal user, user_by_identifier
end

def test_invalid_get_user_by_identifier
user = PassageClient.user.get(user_id: $global_test_user.id)
assert_equal $global_test_user.id, user.id
user = PassageClient.user.get(user_id: @test_user.id)
assert_equal @test_user.id, user.id

assert_raise Passage::PassageError do
PassageClient.user.get_by_identifier(user_identifier: '[email protected]')
end
end

def test_deactivate_user
user = PassageClient.user.deactivate(user_id: $global_test_user.id)
assert_equal $global_test_user.id, user.id
user = PassageClient.user.deactivate(user_id: @test_user.id)
assert_equal @test_user.id, user.id
assert_equal 'inactive', user.status
end

def test_activate_user
user = PassageClient.user.activate(user_id: $global_test_user.id)
assert_equal $global_test_user.id, user.id
user = PassageClient.user.activate(user_id: @test_user.id)
assert_equal @test_user.id, user.id
assert_equal 'active', user.status
end

def test_update_user
new_email = '[email protected]'
user =
PassageClient.user.update(
user_id: $global_test_user.id,
user_id: @test_user.id,
email: new_email,
user_metadata: {
example1: 'lame'
}
)
assert_equal $global_test_user.id, user.id
assert_equal @test_user.id, user.id
assert_equal new_email, user.email
assert_equal 'lame', user.user_metadata[:example1]
end

def test_list_devices
devices = PassageClient.user.list_devices(user_id: $global_test_user.id)
devices = PassageClient.user.list_devices(user_id: @test_user.id)
assert_equal [], devices
end

def test_signout
success = PassageClient.user.signout(user_id: $global_test_user.id)
success = PassageClient.user.signout(user_id: @test_user.id)
assert_equal true, success
end

def teardown
PassageClient.user.delete(user_id: $global_test_user.id)
PassageClient.user.delete(user_id: @test_user.id)
end
end

0 comments on commit 5a15e55

Please sign in to comment.