Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs, deprecate revokeUserDevice create deleteUserDevice #42

Merged
merged 4 commits into from
Dec 19, 2023
Merged

Update docs, deprecate revokeUserDevice create deleteUserDevice #42

merged 4 commits into from
Dec 19, 2023

Conversation

vanessa-passage
Copy link
Contributor

@vanessa-passage vanessa-passage commented Dec 18, 2023 •
edited
Loading

Completed Work

  1. Updates docs.
  2. Deprecates revokeUserDevice for deleteUserDevice. This is in an effort to streamline functions across all SDKs.

rickycpadilla
rickycpadilla approved these changes Dec 19, 2023
View reviewed changes
Copy link

@rickycpadilla rickycpadilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's a small typo, otherwise looks good!

passageidentity/passage.py Outdated
"""
Use Passage API to revoke user devices, look up by user ID
"""
def revokeUserDevice(self, user_id: str, device_id: str) -> Union[bool, PassageError]:
warnings.warn("Passage.revokeUserDevice() is deprecated. Use Passage.deleteUserDevices() instead.", DeprecationWarning)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this should be singular not plural? Passage.deleteUserDevice() instead of Passage.deleteUserDevices()

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@vanessa-passage vanessa-passage merged commit 9f92767 into main Dec 19, 2023
2 checks passed
@ctran88 ctran88 deleted the PSG-3311-gitbook-documentation branch November 21, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickycpadilla rickycpadilla rickycpadilla approved these changes

@bertrmz bertrmz Awaiting requested review from bertrmz

@danilo-kaltner danilo-kaltner Awaiting requested review from danilo-kaltner

@tdeshong tdeshong Awaiting requested review from tdeshong

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vanessa-passage @rickycpadilla