Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: export all models from passageidentity #133

Merged
merged 4 commits into from
Jan 3, 2025

Conversation

ctran88
Copy link
Contributor

@ctran88 ctran88 commented Jan 2, 2025

What's New?

  • Makes all possibly required models available from passageidentity module so they don't have to be imported from longer paths

Example

# old (this can still be used)
from passageidentity import Passage, PassageError
from passageidentity.models.magic_link_args import MagicLinkWithEmailArgs, MagicLinkWithPhoneArgs, MagicLinkWithUserArgs
from passageidentity.models.magic_link_options import MagicLinkOptions
from passageidentity.user import CreateUserArgs, UpdateUserArgs

# new
from passageidentity import (
    CreateUserArgs,
    MagicLinkOptions,
    MagicLinkWithEmailArgs,
    MagicLinkOptions,
    MagicLinkWithPhoneArgs,
    MagicLinkWithUserArgs,
    Passage,
    PassageError,
    UpdateUserArgs,
)

Screenshots (if appropriate):

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have manually tested my code thoroughly
  • I have added/updated inline documentation for public facing interfaces if relevant
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing integration and unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

@ctran88 ctran88 changed the title feat: make all models that may be required by the user available thro… feat: export all models from passageidentity Jan 2, 2025
@ctran88 ctran88 mentioned this pull request Jan 2, 2025
12 tasks
@ctran88 ctran88 marked this pull request as ready for review January 2, 2025 17:05
@ctran88 ctran88 force-pushed the export-all-from-passageidentity branch from cccfb90 to 3ac04b1 Compare January 2, 2025 17:13
Base automatically changed from PSG-5593-rename-codegen-models to main January 3, 2025 17:07
@ctran88 ctran88 force-pushed the export-all-from-passageidentity branch from 3ac04b1 to 977081d Compare January 3, 2025 17:11
Copy link

sonarqubecloud bot commented Jan 3, 2025

@ctran88 ctran88 merged commit 872ba81 into main Jan 3, 2025
6 checks passed
@ctran88 ctran88 deleted the export-all-from-passageidentity branch January 3, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants