Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: update Passage ctor signature to remove deprecated args #132

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

ctran88
Copy link
Contributor

@ctran88 ctran88 commented Dec 23, 2024

What's New?

Screenshots (if appropriate):

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have manually tested my code thoroughly
  • I have added/updated inline documentation for public facing interfaces if relevant
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing integration and unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

@ctran88 ctran88 requested a review from a team December 23, 2024 21:17
@ctran88 ctran88 force-pushed the PSG-5214-remove-deprecated-methods branch from 4c206d6 to 23a00b2 Compare January 2, 2025 19:53
@ctran88 ctran88 force-pushed the update-passage-ctor branch from 7caf5ff to 5afbcb6 Compare January 2, 2025 20:07
@ctran88 ctran88 force-pushed the PSG-5214-remove-deprecated-methods branch from 23a00b2 to 06a1b73 Compare January 3, 2025 17:19
Base automatically changed from PSG-5214-remove-deprecated-methods to main January 3, 2025 17:22
@ctran88 ctran88 force-pushed the update-passage-ctor branch from 5afbcb6 to aed1a10 Compare January 3, 2025 17:28
Copy link

sonarqubecloud bot commented Jan 3, 2025

@ctran88 ctran88 merged commit ac802ca into main Jan 3, 2025
6 checks passed
@ctran88 ctran88 deleted the update-passage-ctor branch January 3, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants