Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: remove deprecated methods and classes #126

Merged
merged 5 commits into from
Jan 3, 2025

Conversation

ctran88
Copy link
Contributor

@ctran88 ctran88 commented Dec 17, 2024

What's New?

  • removes deprecated models
  • removes deprecated methods
  • removes unused helpers
  • removes auth_origin comparison in jwt validation
  • updates magic link classes to use kwargs only

to test (with sdk-tests)

BRANCH=PSG-5214-remove-deprecated-methods task python:test-release -- get-by-identifier

Screenshots (if appropriate):

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have manually tested my code thoroughly
  • I have added/updated inline documentation for public facing interfaces if relevant
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing integration and unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

@ctran88 ctran88 marked this pull request as ready for review December 17, 2024 19:44
@ctran88 ctran88 force-pushed the PSG-5214-remove-deprecated-methods branch 2 times, most recently from aed30fa to 4c206d6 Compare December 23, 2024 20:50
@ctran88 ctran88 requested a review from a team December 23, 2024 20:56
@ctran88 ctran88 force-pushed the PSG-5593-rename-codegen-models branch from c355dff to 036f645 Compare January 2, 2025 16:53
@ctran88 ctran88 force-pushed the PSG-5214-remove-deprecated-methods branch from 4c206d6 to 23a00b2 Compare January 2, 2025 19:53
Copy link
Contributor

@vanessa-passage vanessa-passage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Trying to test

I have the same opinion as the Ruby sdk to wait to merge this last to make development and reviewing faster until the tests in the sdk test repo are connected to the CI.

@bertrmz
Copy link
Contributor

bertrmz commented Jan 3, 2025

There's a remaining .deprecated typing extension in errors.py:

class PassageError(Exception):
"""Error class for handling Passage errors."""
@typing_extensions.deprecated(
"This should only be constructed by the Passage SDK. Use this type just for type checking.",
)

Should the extension be removed or updated with these changes?

EDIT: I see this is addressed in #131. Was there a specific reason for splitting the changes? It seems like they could have been combined.

Base automatically changed from PSG-5593-rename-codegen-models to main January 3, 2025 17:07
@ctran88
Copy link
Contributor Author

ctran88 commented Jan 3, 2025

There's a remaining .deprecated typing extension in errors.py:

class PassageError(Exception):
"""Error class for handling Passage errors."""
@typing_extensions.deprecated(
"This should only be constructed by the Passage SDK. Use this type just for type checking.",
)

Should the extension be removed or updated with these changes?

EDIT: I see this is addressed in #131. Was there a specific reason for splitting the changes? It seems like they could have been combined.

i split them since #131 wasn't just a delete-only change since the user.get_by_identifier method had to be updated as a result

@ctran88 ctran88 force-pushed the PSG-5214-remove-deprecated-methods branch from 23a00b2 to 06a1b73 Compare January 3, 2025 17:19
Copy link

sonarqubecloud bot commented Jan 3, 2025

@ctran88 ctran88 merged commit d4a531e into main Jan 3, 2025
6 checks passed
@ctran88 ctran88 deleted the PSG-5214-remove-deprecated-methods branch January 3, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants