-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: remove deprecated methods and classes #126
Conversation
aed30fa
to
4c206d6
Compare
c355dff
to
036f645
Compare
4c206d6
to
23a00b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. Trying to test
I have the same opinion as the Ruby sdk to wait to merge this last to make development and reviewing faster until the tests in the sdk test repo are connected to the CI.
There's a remaining passage-python/passageidentity/errors.py Lines 13 to 18 in f168b8c
Should the extension be removed or updated with these changes? EDIT: I see this is addressed in #131. Was there a specific reason for splitting the changes? It seems like they could have been combined. |
i split them since #131 wasn't just a delete-only change since the |
23a00b2
to
06a1b73
Compare
Quality Gate passedIssues Measures |
What's New?
to test (with sdk-tests)
Screenshots (if appropriate):
Type of change
Checklist:
Additional context