Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replaces badly formatted error message with one consistent with the other sdks #121

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

ctran88
Copy link
Contributor

@ctran88 ctran88 commented Dec 12, 2024

What's New?

  • get by identifier error message wasn't using the fstring format, f""
  • changed the message anyways to be more consistent with the other sdks

Screenshots (if appropriate):

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have manually tested my code thoroughly
  • I have added/updated inline documentation for public facing interfaces if relevant
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing integration and unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

@ctran88 ctran88 force-pushed the PSG-5564-fix-get-by-identifier-err-msg branch from 42cadb9 to e27de27 Compare December 12, 2024 15:47
@ctran88 ctran88 merged commit 1d32e67 into main Dec 12, 2024
6 checks passed
@ctran88 ctran88 deleted the PSG-5564-fix-get-by-identifier-err-msg branch December 12, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants