-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: updates create_magic_link method to use stronger typed parameters #114
Conversation
d8bf747
to
05021c4
Compare
passageidentity/auth.py
Outdated
language: str | None | ||
magic_link_path: str | None | ||
redirect_url: str | None | ||
ttl: int | None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should be in the models folder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated in a22485f
925d83c
to
a22485f
Compare
a22485f
to
20348c0
Compare
Quality Gate passedIssues Measures |
BEGIN_COMMIT_OVERRIDE
feat: updates create_magic_link method to use stronger typed parameters
feat: add parameter guards to all methods to return early on invalid values
END_COMMIT_OVERRIDE
What's New?
create_magic_link
signature to use a union of types for args and an optional parameter for non-required argscreateMagicLink
method to parse input into the newly typed args to call the new versionScreenshots (if appropriate):
Type of change
Checklist:
Additional context