Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updates create_magic_link method to use stronger typed parameters #114

Merged
merged 5 commits into from
Dec 11, 2024

Conversation

ctran88
Copy link
Contributor

@ctran88 ctran88 commented Dec 5, 2024

BEGIN_COMMIT_OVERRIDE
feat: updates create_magic_link method to use stronger typed parameters

feat: add parameter guards to all methods to return early on invalid values
END_COMMIT_OVERRIDE

What's New?

  • Updates new create_magic_link signature to use a union of types for args and an optional parameter for non-required args
  • Updates old createMagicLink method to parse input into the newly typed args to call the new version

Screenshots (if appropriate):

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have manually tested my code thoroughly
  • I have added/updated inline documentation for public facing interfaces if relevant
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing integration and unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

@ctran88 ctran88 marked this pull request as draft December 5, 2024 23:38
@ctran88 ctran88 force-pushed the PSG-5183-update-create-magic-link-signature branch 2 times, most recently from d8bf747 to 05021c4 Compare December 6, 2024 17:42
@ctran88 ctran88 marked this pull request as ready for review December 6, 2024 17:44
language: str | None
magic_link_path: str | None
redirect_url: str | None
ttl: int | None
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be in the models folder.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated in a22485f

@ctran88 ctran88 force-pushed the PSG-5183-update-create-magic-link-signature branch 3 times, most recently from 925d83c to a22485f Compare December 6, 2024 18:42
@ctran88 ctran88 force-pushed the PSG-5183-update-create-magic-link-signature branch from a22485f to 20348c0 Compare December 11, 2024 04:16
@ctran88 ctran88 mentioned this pull request Dec 11, 2024
12 tasks
Copy link

@ctran88 ctran88 merged commit 83cd628 into main Dec 11, 2024
6 checks passed
@ctran88 ctran88 deleted the PSG-5183-update-create-magic-link-signature branch December 11, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants