Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: change language type to be more strict in magic link options #219

Merged
merged 3 commits into from
Jan 10, 2025

Conversation

ctran88
Copy link
Contributor

@ctran88 ctran88 commented Jan 8, 2025

BEGIN_COMMIT_OVERRIDE
feat!: change language type to be more strict in magic link options

feat: export the union types of CreateMagicLinkArgs for convenience
END_COMMIT_OVERRIDE

What's New?

  • runs codegen updates against latest published schema (using GHA artifact instead of SwaggerHub, which isn't updated)
  • updates MagicLinkOptions.language type

Screenshots (if appropriate):

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have manually tested my code thoroughly
  • I have added/updated inline documentation for public facing interfaces if relevant
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing integration and unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

@ctran88 ctran88 marked this pull request as ready for review January 9, 2025 01:00
@ctran88 ctran88 force-pushed the PSG-5698-use-language-enum branch from 8409bf2 to 031eea2 Compare January 9, 2025 17:37
@ctran88 ctran88 force-pushed the PSG-5698-use-language-enum branch from 031eea2 to 9be0602 Compare January 9, 2025 23:07
Copy link

sonarqubecloud bot commented Jan 9, 2025

@ctran88 ctran88 merged commit 5423a80 into main Jan 10, 2025
6 checks passed
@ctran88 ctran88 deleted the PSG-5698-use-language-enum branch January 10, 2025 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants