Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: removes auth origin comparison from jwt audience validation #214

Merged

Conversation

ctran88
Copy link
Contributor

@ctran88 ctran88 commented Dec 23, 2024

What's New?

Screenshots (if appropriate):

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have manually tested my code thoroughly
  • I have added/updated inline documentation for public facing interfaces if relevant
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing integration and unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

@ctran88 ctran88 requested a review from a team December 23, 2024 20:20
@ctran88 ctran88 merged commit 351d067 into PSG-5213-remove-deprecated-code Dec 30, 2024
6 checks passed
@ctran88 ctran88 deleted the remove-auth-origin-aud-validation branch December 30, 2024 19:46
ctran88 added a commit that referenced this pull request Dec 30, 2024
feat: changes jwt validation to only check app id in audience using the jwt libs validation options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants