Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: removes redundant error message prefixes #213

Merged
merged 2 commits into from
Dec 30, 2024

Conversation

ctran88
Copy link
Contributor

@ctran88 ctran88 commented Dec 23, 2024

What's New?

Screenshots (if appropriate):

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have manually tested my code thoroughly
  • I have added/updated inline documentation for public facing interfaces if relevant
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing integration and unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

@ctran88 ctran88 force-pushed the remove-error-msg-prefix branch from d2875df to 139169b Compare December 23, 2024 20:16
@ctran88 ctran88 requested a review from a team December 23, 2024 20:20
Copy link
Contributor

@flanagankp flanagankp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd also recommend removing the ability to pass in error message prefixes from the PassageBase.parseError method and fromResponseError factory on PassageError

@ctran88
Copy link
Contributor Author

ctran88 commented Dec 30, 2024

I'd also recommend removing the ability to pass in error message prefixes from the PassageBase.parseError method and fromResponseError factory on PassageError

updated in 2125962

@ctran88 ctran88 merged commit d82e314 into PSG-5213-remove-deprecated-code Dec 30, 2024
6 checks passed
@ctran88 ctran88 deleted the remove-error-msg-prefix branch December 30, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants