Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: PSG-5091 Remove JWK re-fetch logic #95

Merged
merged 10 commits into from
Nov 5, 2024

Conversation

tdeshong
Copy link
Contributor

@tdeshong tdeshong commented Oct 29, 2024

BEGIN_COMMIT_OVERRIDE
feat: remove JWK re-fetch logic
END_COMMIT_OVERRIDE

What's New?

Removes extra re-fetching call when JWK fails to find keyID on lookup. Refactor includes using cacheSet instead of individual cache and set.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have manually tested my code thoroughly
  • I have added/updated inline documentation for public facing interfaces if relevant
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing integration and unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

Acceptance Criteria:

  • use JWT libraries to handle JWKS caching instead of doing it manually
  • Remove any refetch calls when the initial JWK call fails.
  • Return error.

@tdeshong tdeshong changed the title PSG-5091 Remove JWK re-fetch logic refactor: PSG-5091 Remove JWK re-fetch logic Oct 30, 2024
@tdeshong tdeshong requested a review from ctran88 October 30, 2024 14:50
@tdeshong tdeshong marked this pull request as ready for review October 30, 2024 15:47
Copy link
Contributor

@ctran88 ctran88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you be able to address the changes discussed in #88 (comment) as well? Sorry, I forgot to mention this earlier

@tdeshong tdeshong requested a review from ctran88 October 31, 2024 17:34
app.go Show resolved Hide resolved
app.go Outdated Show resolved Hide resolved
Copy link

sonarqubecloud bot commented Nov 4, 2024

@tdeshong tdeshong requested a review from ctran88 November 4, 2024 17:13
@tdeshong tdeshong merged commit cf887ab into main Nov 5, 2024
5 checks passed
@tdeshong tdeshong deleted the PSG-5091-remove-jwk-refetch branch November 5, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants