-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add passage error class #105
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdeshong
force-pushed
the
PSG-4995-error-test
branch
from
November 20, 2024 14:59
430267f
to
2e0dfcc
Compare
tdeshong
force-pushed
the
PSG-4995-error-test
branch
from
November 20, 2024 17:17
2e0dfcc
to
bb1d22e
Compare
ctran88
reviewed
Nov 21, 2024
@@ -107,14 +107,19 @@ func (a *App) CreateMagicLink(createMagicLinkBody CreateMagicLinkBody) (*MagicLi | |||
} | |||
|
|||
var errorText string | |||
var errorCode string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could this also be set for GetApp
as well so that its error struct is populated for those that are not ready to move to the major version yet?
ctran88
reviewed
Nov 21, 2024
ctran88
approved these changes
Nov 22, 2024
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's New?
Deprecates and adds some fields in the Passage Error object
Add test for the error cases
Type of change
Checklist:
Additional context