Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add passage error class #105

Merged
merged 37 commits into from
Nov 22, 2024
Merged

feat: add passage error class #105

merged 37 commits into from
Nov 22, 2024

Conversation

tdeshong
Copy link
Contributor

What's New?

Deprecates and adds some fields in the Passage Error object
Add test for the error cases

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have manually tested my code thoroughly
  • I have added/updated inline documentation for public facing interfaces if relevant
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing integration and unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

@tdeshong tdeshong changed the title Psg 4995 error test feat: Psg 4995 error test Nov 19, 2024
@tdeshong tdeshong changed the title feat: Psg 4995 error test feat: Psg 4995 passage error Nov 19, 2024
@tdeshong tdeshong force-pushed the PSG-4995-error-test branch from 430267f to 2e0dfcc Compare November 20, 2024 14:59
@tdeshong tdeshong requested review from ctran88 and bertrmz November 20, 2024 15:03
Base automatically changed from PSG-5154-new-class-method-name to main November 20, 2024 17:09
@tdeshong tdeshong force-pushed the PSG-4995-error-test branch from 2e0dfcc to bb1d22e Compare November 20, 2024 17:17
error.go Show resolved Hide resolved
error.go Show resolved Hide resolved
@@ -107,14 +107,19 @@ func (a *App) CreateMagicLink(createMagicLinkBody CreateMagicLinkBody) (*MagicLi
}

var errorText string
var errorCode string
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could this also be set for GetApp as well so that its error struct is populated for those that are not ready to move to the major version yet?

user.go Show resolved Hide resolved
@tdeshong tdeshong changed the title feat: Psg 4995 passage error feat: passage error Nov 21, 2024
@tdeshong tdeshong requested a review from ctran88 November 21, 2024 20:26
app_user.go Outdated Show resolved Hide resolved
app_user.go Outdated Show resolved Hide resolved
error.go Outdated Show resolved Hide resolved
@tdeshong tdeshong requested a review from ctran88 November 22, 2024 16:51
@ctran88 ctran88 changed the title feat: passage error feat: add passage error class Nov 22, 2024
@ctran88 ctran88 merged commit f0e7239 into main Nov 22, 2024
6 checks passed
@ctran88 ctran88 deleted the PSG-4995-error-test branch November 22, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants