Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSG-4008 - Demo Features #6

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

PSG-4008 - Demo Features #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7583c4
Make Post register prompt, auto login with passkey, and show a login …
blaynebayer May 17, 2024
a0d1774
address pr comments
blaynebayer May 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .env.example
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
PASSAGE_SERVER_PORT=3001
PASSAGE_APP_ID=
PASSAGE_API_KEY=
PASSAGE_API_KEY=
PASSAGE_DISABLE_PASSKEY_PROMPT_AFTER_REGISTER=false
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having env variables to configure the flow is cool - though I worry this will over-complicate the source code for others looking at the demo.

The point of the demo app is really to show the one true Passage recommended™ passkey + password flow

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we never have to merge this, but a good way to get a review!

PASSAGE_DISABLE_AUTO_LOGIN=false
PASSAGE_LOGIN_WITH_PASSKEY_BUTTON=false

Loading