(PC-33734)[API] feat: turn on ENABLE_COLLECTIVE_NEW_STATUSES FF by de… #15666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 0859d11): https://pc-pro-testing--pr15666-pc-33734-eac-back-ch-ust454lx.web.app (expires Sun, 29 Dec 2024 15:26:25 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 032d233ee67e1c50d6af12e29c936c7076770eb1 |
jcicurel-pass
force-pushed
the
PC-33734-eac-back-changer-la-valeur-par-default
branch
from
f3e0720 to
8672c50
Compare
jcicurel-pass
commented
Dec 27, 2024
Comment on lines
+635
to
637
| @override_features(ENABLE_COLLECTIVE_NEW_STATUSES=False) | ||
| # TODO: impossible test case ? Booking limit is now + 3, start and end are now - 5 and offer is pre-booked | ||
| @time_machine.travel("2020-01-05 10:00:00") |
There was a problem hiding this comment.
Supprimer ce test ?
jcicurel-pass
commented
Dec 27, 2024
Comment on lines
+25
to
26
| @override_features(ENABLE_COLLECTIVE_NEW_STATUSES=False) | ||
| def test_create_offer_institution_link(self, client: Any) -> None: |
There was a problem hiding this comment.
Cas un peu particulier ici : avec les nouveaux statuts on peut modifier l'établissement seulement quand l'offre est DRAFT
Par contre on notifie adage seulement si l'offre est APPROVED, donc en l'état on ne va jamais notifier Adage (mais comme c'est seulement quand l'offre est DRAFT c'est peut être OK)
jcicurel-pass
force-pushed
the
PC-33734-eac-back-changer-la-valeur-par-default
branch
from
8672c50 to
0859d11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…fault
But de la pull request
Ticket Jira (ou description si BSR) : https://passculture.atlassian.net/browse/PC-33734
Vérifications