(PC-33722)[API] fix: rm current_user as a parameter inside public route #15665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug: could not cancel an event's stock from the public API if it had at least one booking. The cancellationUserId was an invalid flask login's anonymous user object that was used because the controller called flask login's current_user proxy... which does not make sense since the public API does not rely on flask login. Fix: do not use current_user proxy. User the default value instead (None).
|
Visit the preview URL for this PR (updated for commit e92443f): https://pc-pro-testing--pr15665-pc-33722-fix-public-2my3wkzz.web.app (expires Sun, 29 Dec 2024 11:24:27 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 032d233ee67e1c50d6af12e29c936c7076770eb1 |
jbaudet-pass
temporarily deployed
to
pullrequest
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But de la pull request
Ticket Jira (ou description si BSR) : https://passculture.atlassian.net/browse/PC-33722
Bug : impossible d'annuler le stock d'un événement via l'API publique si celui-ci a au moins une réservation.
Fix : ne pas utiliser
current_userdans l'API publique puisqu'il renvoie un objet représentant un utilisateur anonyme (logique, puisqu'elle n'utilise pas flask login) ce qui créé quelques étincelles au moment de mettre à jour la réservation ("cancellationUserIddoit être un entier").