Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PC-32747)[API] feat: fix schema typing and set startDatetime and end… #15664

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jcicurel-pass
Copy link
Contributor

@jcicurel-pass jcicurel-pass commented Dec 26, 2024

…Datetime not null on collective stock

But de la pull request

Ticket Jira (ou description si BSR) : https://passculture.atlassian.net/browse/PC-32747

Requête sur Metabase :

select cs.id, cs."startDatetime", cs."endDatetime"
from collective_stock cs
where cs."startDatetime" is NULL or cs."endDatetime" is null;

0 résultat en prod

Vérifications

  • J'ai écrit les tests nécessaires
  • J'ai mis à jour le fichier des plans de tests du portail pro si nécessaire
  • J'ai mis à jour la liste des routes et des titres de pages du portail pro si j'en ai rajouté/modifié ou supprimé une.
  • J'ai relu attentivement les migrations, en particulier pour éviter les locks, et je préviens les équipes Shérif et Data
  • J'ai ajouté des screenshots pour d'éventuels changements graphiques
  • J'ai fait la revue fonctionnelle de mon ticket

Copy link
Contributor

github-actions bot commented Dec 26, 2024

mypy cop report: 464 (master) = 464 (your branch)

@jcicurel-pass jcicurel-pass force-pushed the PC-32747-eac-back-corriger-le-typage-de-end-datetime branch 2 times, most recently from 470dbef to 6ba2dbf Compare December 26, 2024 17:04
Copy link
Contributor

github-actions bot commented Dec 26, 2024

Visit the preview URL for this PR (updated for commit e3a1ad9):

https://pc-pro-testing--pr15664-pc-32747-eac-back-co-uzfmzqc5.web.app

(expires Sun, 29 Dec 2024 09:05:09 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 032d233ee67e1c50d6af12e29c936c7076770eb1

@jcicurel-pass jcicurel-pass force-pushed the PC-32747-eac-back-corriger-le-typage-de-end-datetime branch from 6ba2dbf to e0738be Compare December 26, 2024 17:20
@jcicurel-pass jcicurel-pass force-pushed the PC-32747-eac-back-corriger-le-typage-de-end-datetime branch from e0738be to e3a1ad9 Compare December 27, 2024 08:55
@jcicurel-pass jcicurel-pass marked this pull request as ready for review December 27, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants