(PC-32282)[PRO] fix: Don't reset location label in generic function #14545
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 2fce319): https://pc-pro-testing--pr14545-pc-32282-ne-pas-vide-wra4djhs.web.app (expires Fri, 11 Oct 2024 14:38:18 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 032d233ee67e1c50d6af12e29c936c7076770eb1 |
AmineLouveau
approved these changes
Oct 10, 2024
Comment on lines
+65
to
+66
| await formik.setFieldValue('locationLabel', '') | ||
| await formik.setFieldTouched('locationLabel', false) |
There was a problem hiding this comment.
C'est pas ce qui est fait dans resetAddressFields ?
There was a problem hiding this comment.
Au départ si, mais resetAddressFields est appelé à deux endroits, et pour l'un des deux on ne souhaite pas réinitialiser le champs "label" (origine du ticket)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But de la pull request
Ticket Jira (ou description si BSR) : https://passculture.atlassian.net/browse/PC-32282