(PC-31530)[PRO] feat: ab test for suggested subactegories #13966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 24921b5): https://pc-pro-testing--pr13966-pc-31530-abtest-sugg-yw62pk5s.web.app (expires Sat, 07 Sep 2024 09:13:34 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 032d233ee67e1c50d6af12e29c936c7076770eb1 |
xdekoninck-pass
approved these changes
Sep 4, 2024
jclery-pass
reviewed
Sep 4, 2024
Comment on lines
86
to
90
| offer === null | ||
| ? setDefaultInitialValues({ | ||
| filteredVenues, | ||
| areSuggestedCategoriesEnabled, | ||
| areSuggestedCategoriesEnabled: areSuggestedSubcategoriesUsed, | ||
| }) |
There was a problem hiding this comment.
Je chipote un peu, mais on pourrait nommer la constante du hook plus haut avec le même nom que la propriété de cet objet :
const areSuggestedCategoriesEnabled = useSuggestedSubcategoriesAbTest()
// …
offer === null
? setDefaultInitialValues({
filteredVenues,
areSuggestedCategoriesEnabled // Ca fait juste plus élégant ?
})
: … ;There was a problem hiding this comment.
alors je me suis poser la même question et je me suis dit que le suffixe enabled était souvent utilisé pour les ff et que comme ça on confondait pas mais en vrai je peux faire comme tu dis !
jclery-pass
approved these changes
Sep 4, 2024
Aliochka
force-pushed
the
PC-31530-abTest-suggested-subcategories
branch
from
9bd203e
to
24921b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But de la pull request
Ticket Jira (ou description si BSR) : https://passculture.atlassian.net/browse/PC-31530
Vérifications