Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PC-31643)[API] chore: change recommendation endpoints urls for ehp #13962

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

mageoffray
Copy link
Contributor

@mageoffray mageoffray commented Sep 4, 2024

But de la pull request

Ticket Jira (ou description si BSR) : https://passculture.atlassian.net/browse/PC-31643

Theses configs will now be defined in the deployment repo for ehp : https://github.com/pass-culture/pass-culture-deployment/pull/455/commits/5d848910e109a689a20cec8c99a347df10165387

Vérifications

  • J'ai écrit les tests nécessaires
  • J'ai mis à jour le fichier des plans de tests du portail pro si nécessaire
  • J'ai mis à jour la liste des routes et des titres de pages du portail pro si j'en ai rajouté/modifié ou supprimé une.
  • J'ai relu attentivement les migrations, en particulier pour éviter les locks, et je préviens les équipes Shérif et Data
  • J'ai ajouté des screenshots pour d'éventuels changements graphiques

@mageoffray mageoffray changed the title (PC-31643)[API] chore: change recommendation endpoints urls (PC-31643)[API] chore: change recommendation endpoints urls for ehp Sep 4, 2024
Comment on lines +75 to +77
verify = False
if settings.IS_PROD:
verify = True
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Détail : ça doit être équivalent à : verify = settings.IS_PROD, plus simplement.
Mais je comprends que c'est temporaire.

@mageoffray mageoffray merged commit 7ce2ba0 into master Sep 5, 2024
23 checks passed
@mageoffray mageoffray deleted the mageoffray/pc-31643-change-recommendation-urls branch September 5, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants