(PC-31580)[API] chore: add script to migrate Les Libraires to new pulic API provider (Part 1/2) #13948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lic API provider (Part 1/2)
jeremieb-pass
approved these changes
Sep 3, 2024
| 12946, | ||
| 46994, | ||
| ], | ||
| 2568200, # id of our backend tech lead user |
There was a problem hiding this comment.
Le commentaire est peut-être à enlever, on est sur un repo public et c'est une information relativement spécifique.
There was a problem hiding this comment.
La fois d'avant c'était carrément son email qui était montré mais tu as raison j'enlève ça.
|
|
||
|
|
||
| def delete_venue_provider(venue_provider: providers_models.VenueProvider, author: users_models.User) -> None: | ||
| update_venue_synchronized_offers_active_status_job.delay(venue_provider.venueId, venue_provider.providerId, False) |
There was a problem hiding this comment.
Attention, si un lieu a beaucoup (beaucoup) d'offres, la tâche peut planter. Ca vaudra le coup de bien surveiller les logs pour s'assurer que la tâche n'a pas planté.
There was a problem hiding this comment.
Je vais checker ça sur staging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But de la pull request
Ticket Jira: https://passculture.atlassian.net/browse/PC-31580
Won't be merged, will be run using the job console.
Vérifications