(PC-31571)[API] feat: discord auth full flow from our form #13934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lixxday
force-pushed
the
PC-31571-update-discord-flow
branch
from
00540db
to
1363927
Compare
thconte
reviewed
Sep 3, 2024
lixxday
force-pushed
the
PC-31571-update-discord-flow
branch
from
1363927
to
a060eb0
Compare
lixxday
force-pushed
the
PC-31571-update-discord-flow
branch
from
a060eb0
to
0b29141
Compare
cepehang
approved these changes
Sep 4, 2024
| if discord_user is None: | ||
| # We still add the user to the database even if he doesn't have access to the discord server | ||
| discord_user = user_models.DiscordUser(userId=user.id, discordId=discord_id, hasAccess=False) | ||
| db.session.add(discord_user) |
There was a problem hiding this comment.
il faudrait prendre l'habitude de db.session.flush() juste après les add pour éviter que des erreurs potentielles soient remontées au niveau du décorateur atomic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But de la pull request
Ticket Jira (ou description si BSR) : https://passculture.atlassian.net/browse/PC-31571
Vérifications
Screen pas ouf d'une réussite au 3e essai
https://github.com/user-attachments/assets/5cf37f56-4ea2-4b42-9e75-2ee093a0d2be