(PC-31604)[BO] fix: when user is already anonymized button to anonymize should not appear #13933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blbpro
force-pushed
the
PC-31604_button_anonymise_appear_on_beneficiary_already_anonymised
branch
from
22b3436
to
c96a249
Compare
prouzet
reviewed
Sep 3, 2024
blbpro
force-pushed
the
PC-31604_button_anonymise_appear_on_beneficiary_already_anonymised
branch
2 times, most recently
from
10e837c
to
9d41aa5
Compare
Comment on lines
+409
to
+413
| if ( | ||
| utils.has_current_user_permission(perm_models.Permissions.ANONYMIZE_PUBLIC_ACCOUNT) | ||
| and not _has_user_pending_anonymization(user_id) | ||
| and users_models.UserRole.ANONYMIZED not in user.roles | ||
| ): |
There was a problem hiding this comment.
Il manque un petit test :)
There was a problem hiding this comment.
A vrai dire, j'ai justement pensé qu'un test n'était pas nécéssaire pour ce cas spécifique étant donné les tests en backend mais très bien, je vais faire le test
There was a problem hiding this comment.
Ça me semble bien, je laisse Patrick approuver si ça lui convient
…ze should not appear
blbpro
force-pushed
the
PC-31604_button_anonymise_appear_on_beneficiary_already_anonymised
branch
from
9d41aa5
to
8a2d0bb
Compare
prouzet
approved these changes
Sep 3, 2024
blbpro
deleted the
PC-31604_button_anonymise_appear_on_beneficiary_already_anonymised
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But de la pull request
Ticket Jira (ou description si BSR) : https://passculture.atlassian.net/browse/PC-31604
verification front
A présent lorsque l'on a deja anonymisé un utilisateur de plus de 21 ans, le bouton anonymisé aura disparu pour des raisons évidente de clarté:
verification back
cas de test détecté:
c'est du front aucun test ( voir image)
Verification ticket
Tache restante si WIP + AUTRE