Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PC-30946)[PRO] feat: Adds warning popup when updating a venue address that have offers #13909

Conversation

jclery-pass
Copy link
Contributor

But de la pull request

Ticket Jira (ou description si BSR) : https://passculture.atlassian.net/browse/PC-30946

@jclery-pass jclery-pass changed the title Pc 30946 modale dinformation lors du changement dadresse de la venue (PC-30946)[PRO] feat: Adds warning popup when updating a venue address that have offers Aug 30, 2024
Copy link
Contributor

github-actions bot commented Aug 30, 2024

Visit the preview URL for this PR (updated for commit 4808e63):

https://pc-pro-testing--pr13909-pc-30946-modale-dinf-652u0u5v.web.app

(expires Thu, 05 Sep 2024 19:38:43 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 032d233ee67e1c50d6af12e29c936c7076770eb1

Copy link
Contributor

@GuillaumeMgz GuillaumeMgz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

En local j'essaie de modifier l'adresse, j'ai bien le dialog que tu as ajouté, je valide, je vois le PATCH, mais au reload l'adresse du lieu est encore la même, est-ce que tu reproduis ?

@jclery-pass
Copy link
Contributor Author

En local j'essaie de modifier l'adresse, j'ai bien le dialog que tu as ajouté, je valide, je vois le PATCH, mais au reload l'adresse du lieu est encore la même, est-ce que tu reproduis ?

Yep, c'est dû au fait qu'il y a côté back-end un "bouchon" pour éviter de faire trop d'appels à l'API Adresse.

Si tu veux pouvoir le tester en local, il faut dans ton fichier api/.env.development remplacer la variable d'environnement suivante :

# ADRESSE_BACKEND=pcapi.connectors.api_adresse.TestingBackend
ADRESSE_BACKEND=pcapi.connectors.api_adresse.ApiAdresseBackend

… et relancer le conteneur pc-api

@jclery-pass jclery-pass force-pushed the PC-30946-modale-dinformation-lors-du-changement-dadresse-de-la-venue branch from 9870349 to 7dbccc9 Compare September 3, 2024 19:12
@jclery-pass jclery-pass force-pushed the PC-30946-modale-dinformation-lors-du-changement-dadresse-de-la-venue branch from 7dbccc9 to 4808e63 Compare September 3, 2024 19:15
@jclery-pass jclery-pass merged commit 53959da into master Sep 4, 2024
16 of 18 checks passed
@jclery-pass jclery-pass deleted the PC-30946-modale-dinformation-lors-du-changement-dadresse-de-la-venue branch September 4, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants