PC-31042 add new categories management #13474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
thconte
force-pushed
the
pc-31042-add-new-categories-management
branch
9 times, most recently
from
2b42727
to
ed3eb94
Compare
thconte
force-pushed
the
pc-31042-add-new-categories-management
branch
4 times, most recently
from
7cb2865
to
df13f2e
Compare
thconte
force-pushed
the
pc-31042-add-new-categories-management
branch
4 times, most recently
from
12b42e3
to
f94d7e7
Compare
tanguyprache
approved these changes
Aug 30, 2024
thconte
force-pushed
the
pc-31042-add-new-categories-management
branch
4 times, most recently
from
cfaf19e
to
12c7a4e
Compare
thconte
commented
Sep 3, 2024
thconte
commented
Sep 3, 2024
thconte
commented
Sep 3, 2024
thconte
force-pushed
the
pc-31042-add-new-categories-management
branch
from
12c7a4e
to
dd9ccac
Compare
cepehang
approved these changes
Sep 3, 2024
| return self.label | ||
|
|
||
|
|
||
| def book_nodes() -> list[BookGenre]: |
There was a problem hiding this comment.
Suggested change
| def book_nodes() -> list[BookGenre]: | |
| def get_book_nodes() -> list[BookGenre]: |
pareil pour les autres fonctions qui récupèrent une liste, c'est surtout important ici parce book veut dire à la fois livre et réserver
…earchGroupNamev2`
thconte
force-pushed
the
pc-31042-add-new-categories-management
branch
from
dd9ccac
to
0f0cc7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But de la pull request
Ticket Jira (ou description si BSR) : https://passculture.atlassian.net/browse/PC-31042
Vérifications