Skip to content

(PC-31217)[API]feat: add new validation for post and patch offer regarding EAN code #3954

(PC-31217)[API]feat: add new validation for post and patch offer regarding EAN code

(PC-31217)[API]feat: add new validation for post and patch offer regarding EAN code #3954

Triggered via pull request September 3, 2024 14:45
Status Failure
Total duration 19m 5s
Artifacts 6
Tests pro  /  ...  /  Style quality check
1m 38s
Tests pro / Type check / Quality check / Style quality check
Tests pro  /  Unit tests
8m 17s
Tests pro / Unit tests
[pcapi-tests] build docker image.  /  Build pcapi-tests:b32cbddd69d45606722f007465e3dc227291f19e
3m 55s
[pcapi-tests] build docker image. / Build pcapi-tests:b32cbddd69d45606722f007465e3dc227291f19e
[pcapi] build docker image.  /  Build pcapi:b32cbddd69d45606722f007465e3dc227291f19e
2m 14s
[pcapi] build docker image. / Build pcapi:b32cbddd69d45606722f007465e3dc227291f19e
[pcapi-console] build docker image.  /  Build pcapi-console:b32cbddd69d45606722f007465e3dc227291f19e
3m 31s
[pcapi-console] build docker image. / Build pcapi-console:b32cbddd69d45606722f007465e3dc227291f19e
MyPy cop  /  MyPy cop test
31s
MyPy cop / MyPy cop test
Tests API documentation  /  Check API documentation can be built
Tests API documentation / Check API documentation can be built
[PRO] Deploy PR version for validation  /  deploy_on_firebase
1m 19s
[PRO] Deploy PR version for validation / deploy_on_firebase
Dependabot  /  dependabot
Dependabot / dependabot
Matrix: Tests api / Pytest
Tests api  /  Quality checks
2m 43s
Tests api / Quality checks
Tests api  /  Pylint
5m 41s
Tests api / Pylint
Tests api  /  Test database schema
3m 6s
Tests api / Test database schema
Tests pro E2E  /  E2E tests and notifications
15m 40s
Tests pro E2E / E2E tests and notifications
Update api client template  /  Update API Client template
1m 58s
Update api client template / Update API Client template
Push pcapi docker image to registry  /  push-docker-image
Push pcapi docker image to registry / push-docker-image
Push pcapi-console docker image to registry  /  push-docker-image
Push pcapi-console docker image to registry / push-docker-image
Fit to window
Zoom out
Zoom in

Annotations

11 errors, 60 warnings, and 4 notices
tests/core/offers/test_api.py.test_create_draft_offer_from_scratch: tests/core/offers/test_api.py#L1059
TypeError: create_draft_offer() missing 1 required positional argument: 'product'
tests/core/offers/test_api.py.test_create_draft_offer_with_virtual_venue: tests/core/offers/test_api.py#L1077
TypeError: create_draft_offer() missing 1 required positional argument: 'product'
tests/core/offers/test_api.py.test_create_draft_offer_with_virtual_venue_with_subcategory_suggestion_must_fail: tests/core/offers/test_api.py#L1099
TypeError: create_draft_offer() missing 1 required positional argument: 'product'
tests/core/offers/test_api.py.test_create_draft_offer_with_accessibility_provider: tests/core/offers/test_api.py#L1110
TypeError: create_draft_offer() missing 1 required positional argument: 'product'
tests/core/offers/test_api.py.test_cannot_create_activation_offer: tests/core/offers/test_api.py#L1145
TypeError: create_draft_offer() missing 1 required positional argument: 'product'
tests/core/offers/test_api.py.test_cannot_create_offer_when_invalid_subcategory: tests/core/offers/test_api.py#L1158
TypeError: create_draft_offer() missing 1 required positional argument: 'product'
tests/core/offers/test_api.py.test_create_offer_with_online_subcategory_must_be_on_virtual_venue: tests/core/offers/test_api.py#L1170
TypeError: create_draft_offer() missing 1 required positional argument: 'product'
tests/core/offers/test_api.py.test_create_offer_with_offline_subcategory_must_be_on_physical_venue: tests/core/offers/test_api.py#L1184
TypeError: create_draft_offer() missing 1 required positional argument: 'product'
tests/core/offers/test_api.py.test_create_offer_with_online_subcategory_with_no_virtual_venue_must_fail: tests/core/offers/test_api.py#L1198
TypeError: create_draft_offer() missing 1 required positional argument: 'product'
Tests pro E2E / E2E tests and notifications
Cypress tests: 1 failed
Tests pro / Type check / Quality check / Style quality check
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Tests pro / Type check / Quality check / Style quality check: pro/src/app/App/App.tsx#L82
React Hook useEffect has a missing dependency: 'dispatch'. Either include it or remove the dependency array
Tests pro / Type check / Quality check / Style quality check: pro/src/app/App/hook/useLogExtraProData.ts#L25
React Hook useEffect has missing dependencies: 'location.pathname', 'logEvent', and 'previousOfferer'. Either include them or remove the dependency array
Tests pro / Type check / Quality check / Style quality check: pro/src/app/App/hook/useLogNavigation.ts#L32
React Hook useEffect has missing dependencies: 'params' and 'previousPage'. Either include them or remove the dependency array
Tests pro / Type check / Quality check / Style quality check: pro/src/app/App/hook/usePageTitle.ts#L16
React Hook useEffect has a missing dependency: 'location'. Either include it or remove the dependency array
Tests pro / Type check / Quality check / Style quality check: pro/src/components/Address/Address.tsx#L43
React Hook useEffect has a missing dependency: 'selectedField.value'. Either include it or remove the dependency array
Tests pro / Type check / Quality check / Style quality check: pro/src/components/Address/Address.tsx#L85
React Hook useEffect has missing dependencies: 'addressesMap', 'searchField', and 'setFieldValue'. Either include them or remove the dependency array
Tests pro / Type check / Quality check / Style quality check: pro/src/components/ImageUploader/ButtonImageEdit/ModalImageEdit/ModalImageEdit.tsx#L69
React Hook useEffect has missing dependencies: 'initialImageUrl', 'initialOriginalImageUrl', and 'notification'. Either include them or remove the dependency array
Tests pro / Type check / Quality check / Style quality check: pro/src/components/IndividualOfferForm/Notifications/Notifications.tsx#L36
React Hook useEffect has missing dependencies: 'bookingEmail', 'currentUser.email', 'setFieldValue', and 'venueBookingEmail'. Either include them or remove the dependency array
Tests pro / Type check / Quality check / Style quality check: pro/src/components/IndividualOfferForm/UsefulInformations/TicketWithdrawal/TicketWithdrawal.tsx#L49
React Hook useEffect has missing dependencies: 'dirty', 'getFirstWithdrawalTypeEnumValue', and 'setFieldValue'. Either include them or remove the dependency array
Tests pro / Type check / Quality check / Style quality check: pro/src/components/StocksEventList/StocksEventList.tsx#L190
React Hook useEffect has missing dependencies: 'handleStocksResponse', 'loadStocksFromCurrentFilters', 'searchParams', and 'setSearchParams'. Either include them or remove the dependency array
Update api client template / Update API Client template
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/setup-node@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Update api client template / Update API Client template
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v2, actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Tests api / Quality checks
The following actions uses node12 which is deprecated and will be forced to run on node16: docker/login-action@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Tests api / Quality checks
The following actions use a deprecated Node.js version and will be forced to run on node20: docker/login-action@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Tests api / Quality checks
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Tests api / Quality checks
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Tests api / Quality checks
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Tests api / Pytest (tests --ignore=tests/core --ignore=tests/routes)
The following actions uses node12 which is deprecated and will be forced to run on node16: docker/login-action@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Tests api / Pytest (tests --ignore=tests/core --ignore=tests/routes)
The following actions use a deprecated Node.js version and will be forced to run on node20: docker/login-action@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Tests api / Pytest (tests --ignore=tests/core --ignore=tests/routes)
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Tests api / Pytest (tests --ignore=tests/core --ignore=tests/routes)
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Tests api / Pytest (tests --ignore=tests/core --ignore=tests/routes)
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Tests api / Test database schema
The following actions uses node12 which is deprecated and will be forced to run on node16: docker/login-action@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Tests api / Test database schema
The following actions use a deprecated Node.js version and will be forced to run on node20: docker/login-action@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Tests api / Test database schema
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Tests api / Test database schema
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Tests api / Test database schema
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Tests pro / Unit tests
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Tests api / Pytest (tests/core --ignore=tests/core/bookings --ignore=tests/core/offers --ignore=tests/core/fi...
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Tests api / Pytest (tests/core --ignore=tests/core/bookings --ignore=tests/core/offers --ignore=tests/core/fi...
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Tests api / Pytest (tests/core --ignore=tests/core/bookings --ignore=tests/core/offers --ignore=tests/core/fi...
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Tests api / Pytest (tests/core/bookings tests/core/offers tests/core/finance)
The following actions uses node12 which is deprecated and will be forced to run on node16: docker/login-action@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Tests api / Pytest (tests/core/bookings tests/core/offers tests/core/finance)
The following actions use a deprecated Node.js version and will be forced to run on node20: docker/login-action@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Tests api / Pytest (tests/core/bookings tests/core/offers tests/core/finance)
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Tests api / Pytest (tests/core/bookings tests/core/offers tests/core/finance)
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Tests api / Pytest (tests/core/bookings tests/core/offers tests/core/finance)
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
[PRO] Deploy PR version for validation / deploy_on_firebase
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Tests api / Pylint
The following actions uses node12 which is deprecated and will be forced to run on node16: docker/login-action@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Tests api / Pylint
The following actions use a deprecated Node.js version and will be forced to run on node20: docker/login-action@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Tests api / Pylint
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Tests api / Pylint
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Tests api / Pylint
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Tests api / Pytest (tests/routes -m 'not backoffice')
The following actions uses node12 which is deprecated and will be forced to run on node16: docker/login-action@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Tests api / Pytest (tests/routes -m 'not backoffice')
The following actions use a deprecated Node.js version and will be forced to run on node20: docker/login-action@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Tests api / Pytest (tests/routes -m 'not backoffice')
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Tests api / Pytest (tests/routes -m 'not backoffice')
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Tests api / Pytest (tests/routes -m 'not backoffice')
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Tests api / Pytest (tests/routes/backoffice -m 'backoffice')
The following actions uses node12 which is deprecated and will be forced to run on node16: docker/login-action@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Tests api / Pytest (tests/routes/backoffice -m 'backoffice')
The following actions use a deprecated Node.js version and will be forced to run on node20: docker/login-action@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Tests api / Pytest (tests/routes/backoffice -m 'backoffice')
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Tests api / Pytest (tests/routes/backoffice -m 'backoffice')
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Tests api / Pytest (tests/routes/backoffice -m 'backoffice')
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Tests pro E2E / E2E tests and notifications
The following actions uses node12 which is deprecated and will be forced to run on node16: docker/login-action@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Tests pro E2E / E2E tests and notifications
The following actions use a deprecated Node.js version and will be forced to run on node20: technote-space/workflow-conclusion-action@v3, docker/login-action@v1, actions/setup-node@v3, actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Tests pro E2E / E2E tests and notifications
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Tests pro E2E / E2E tests and notifications
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Tests pro E2E / E2E tests and notifications
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Update api client template / Update API Client template
Running update api client template with europe-west1-docker.pkg.dev/passculture-infra-prod/pass-culture-artifact-registry/pcapi:b32cbddd69d45606722f007465e3dc227291f19e
Tests api / Quality checks
Running tests api with europe-west1-docker.pkg.dev/passculture-infra-prod/pass-culture-artifact-registry/pcapi-tests:b32cbddd69d45606722f007465e3dc227291f19e
[PRO] Deploy PR version for validation / deploy_on_firebase
Firebase deployment is available at : https://pc-pro-testing--pr13872-pcharlet-pc-31217-dr-sweml5pi.web.app
Tests pro E2E / E2E tests and notifications
Running e2e-tests with europe-west1-docker.pkg.dev/passculture-infra-prod/pass-culture-artifact-registry/pcapi:b32cbddd69d45606722f007465e3dc227291f19e

Artifacts

Produced during runtime
Name Size
pass-culture~pass-culture-main~30Q4HT.dockerbuild
93.3 KB
pass-culture~pass-culture-main~BZVVCH.dockerbuild
78.9 KB
pass-culture~pass-culture-main~J6BPX6.dockerbuild
158 KB
pcapi-b32cbddd69d45606722f007465e3dc227291f19e.tar Expired
294 MB
pcapi-console-b32cbddd69d45606722f007465e3dc227291f19e.tar Expired
466 MB
pcapi-tests-b32cbddd69d45606722f007465e3dc227291f19e.tar Expired
532 MB