-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(BSR) docs(AutocompleteOfferItem): add BPMN #7511
base: master
Are you sure you want to change the base?
(BSR) docs(AutocompleteOfferItem): add BPMN #7511
Conversation
c4e2f36
to
5eb4513
Compare
5eb4513
to
2915452
Compare
AutocompleteOfferItem
Quality Gate passedIssues Measures |
Quality Gate passedIssues Measures |
@@ -0,0 +1,15 @@ | |||
flowchart LR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
je le trouve plus lisible en vertical
flowchart LR | |
flowchart TB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
J'ai pas de préférence, je prends ta suggestion
A(( )) --> C{Is there a suggestion?} | ||
C --> |YES| D{Is there a subcategory suggested?} | ||
C --> |NO| E[display '$query'] | ||
D --> |YES| F{Does suggested subcategory fit in context?} | ||
D --> |NO| G{Is there a top level category suggested?} | ||
E --> L((( ))) | ||
F --> |YES| H{Has suggested subcategory exactly 1 parent?} | ||
F --> |NO| G | ||
G --> |YES| K[display '$query dans $category'] | ||
G --> |NO| E | ||
H --> |YES| J[display '$query dans $subcategory'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
je trouve ça plus facilement compréhensible avec des petits losanges
A(( )) --> C{Is there a suggestion?} | |
C --> |YES| D{Is there a subcategory suggested?} | |
C --> |NO| E[display '$query'] | |
D --> |YES| F{Does suggested subcategory fit in context?} | |
D --> |NO| G{Is there a top level category suggested?} | |
E --> L((( ))) | |
F --> |YES| H{Has suggested subcategory exactly 1 parent?} | |
F --> |NO| G | |
G --> |YES| K[display '$query dans $category'] | |
G --> |NO| E | |
H --> |YES| J[display '$query dans $subcategory'] | |
A(( )) --> C{{Is there a suggestion?}} | |
C --> |YES| D{{Is there a subcategory suggested?}} | |
C --> |NO| E[display '$query'] | |
D --> |YES| F{{Does suggested subcategory fit in context?}} | |
D --> |NO| G{{Is there a top level category suggested?}} | |
E --> L((( ))) | |
F --> |YES| H{{Has suggested subcategory exactly 1 parent?}} | |
F --> |NO| G | |
G --> |YES| K[display '$query dans $category'] | |
G --> |NO| E | |
H --> |YES| J[display '$query dans $subcategory'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C'était pour suivre le standard BPMN
Flakiness
If I had to re-run tests in the CI due to flakiness, I add the incident on Notion
Checklist
I have:
Screenshots
delete if no UI change
Best Practices
Click to expand
These rules apply to files that you make changes to. If you can't respect one of these rules, be sure to explain why with a comment. If you consider correcting the issue is too time consuming/complex: create a ticket. Link the ticket in the code.as
(type assertions are removed at compile-time, there is no runtime checking associated with a type assertion. There won’t be an exception ornull
generated if the type assertion is wrong). In certain casesas const
is acceptable (for example when defining readonly arrays/objects). Usingas
in tests is tolerable.any
(when you want to accept anything because you will be blindly passing it through without interacting with it, you can useunknown
). Usingany
in tests is tolerable.!
when you know that the value can’t benull
orundefined
).@ts-expect-error
and@eslint-disable
.yarn test:lint
,yarn test:types
,yarn start:web
...).gap
(ViewGap
) instead of<Spacer.Column />
,<Spacer.Row />
or<Spacer.Flex />
.Test specific:
user
tofireEvent
.setFeatureFlags
. If not possible, mention which one(s) you want to mock in a comment (example:jest.spyOn(useFeatureFlagAPI, 'useFeatureFlag').mockReturnValue(true) // WIP_NEW_OFFER_TILE in renderPassPlaylist.tsx
)await act(async () => {})
andawait waitFor(/* ... */)
byawait screen.findBySomething()
.act
by default andwaitFor
as a last resort.Advice: