Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(DE-1025) feat(deps): export obfuscated data #3758

Open
wants to merge 34 commits into
base: master
Choose a base branch
from

Conversation

vbusson-pass
Copy link
Collaborator

PR template

Select PR template in preview mode

PR title format (except for MEP)

There is a linter on the PR title format. Please respect the following format:

(ticket) type(topic): comment
  • ticket surrounded by parenthesis, with optionnaly a hyphen followed by one or more digits (e.g., -1234). The first part must be one of the following strings:

    • DA
    • DE
    • AE
    • DS
    • HF
    • BSR
    • PC
  • type :
    The second part to specify the type of change one of the following :

    • build
    • lint
    • ci
    • docs
    • feat
    • fix
    • perf
    • refactor
    • test
    • chore
    • dbt
  • topic within parenthesis: 1 word e.g., (dag)

  • comment: tell us your life

examples:

  • ✅ (DE-124) refactor(firebase): update source field
  • ❌ (DE-124) refactor (firebase): update source field (space between type and topic)
  • ❌ (DE-124) airflow(firebase): update source fiedd in DAG (wrong type)
  • ❌ (DE-124) (DE-124) refactor(firebase refacto): update source field (topic in two words)
  • ✅ (BSR) docs(github): add PR title valid format in template

@vbusson-pass vbusson-pass force-pushed the master branch 2 times, most recently from 174fb91 to a57b4fc Compare January 29, 2025 08:09
cdelabre-pass
cdelabre-pass previously approved these changes Jan 30, 2025
Copy link
Collaborator

@cdelabre-pass cdelabre-pass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pas très très concret pour le moment, je serais intéressé pour avoir les tables en exemple afin de voir si cela correspond à ce que l'on souhaite !

orchestration/dags/jobs/dbt/dbt_ministry_export.py Outdated Show resolved Hide resolved
@vbusson-pass vbusson-pass force-pushed the DE-1025-obfuscation branch 6 times, most recently from caa53ab to 0c1edd3 Compare January 31, 2025 01:09
@vbusson-pass vbusson-pass force-pushed the DE-1025-obfuscation branch 4 times, most recently from 6c04cf6 to f17789a Compare January 31, 2025 11:33
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants