(DA-3938) feat(dbt): Add movie label to offer_metadata #3679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,8 @@ | |||
| select | |||
| movie_status as movie_label, | |||
| split(movie_visa, '.')[offset(0)] as movie_visa, | |||
There was a problem hiding this comment.
Privilégier le safe_cast en excluant les valeurs "nan" pour que ça fonctionne :)
| @@ -159,4 +162,7 @@ left join | |||
| {{ ref("int_applicative__product_mediation") }} as pm | |||
| on o.offer_product_id = pm.product_id | |||
| left join {{ ref("int_applicative__product") }} as p on o.offer_product_id = p.id | |||
| left join | |||
| {{ ref("int_seed__movie_arthouse_and_heritage_label") }} as mahl | |||
There was a problem hiding this comment.
il y a certains visas qui ont deux lignes dans la table raw (2 lignes pour un même visa et un même movie_status), j'ai peur que ça duplique des lignes sur cette table non ?
There was a problem hiding this comment.
je ne garde qu'une ligne dans le modèle int_seed__movie_arthouse_and_heritage_label en faisant un QUALIFY donc on devrait éviter les doublons
| movie_distributor, | ||
| cast(movie_release_date as date) as movie_release_date, | ||
| safe_cast(safe_cast(movie_visa as float64) as string) as movie_visa | ||
| from {{ source("seed", "gsheet_movie_arthouse_and_heritage_label") }} |
cdelabre-pass
requested changes
Jan 8, 2025
orchestration/dags/data_gcp_dbt/models/mart/global/mrt_global__offer_metadata.sql
Outdated
Show resolved
Hide resolved
|
| - name: offer_isbn | ||
| description: "{{ doc('column__isbn') }}" | ||
| - name: offer_visa | ||
| description: "{{ doc('column__visa') }}" |
| @@ -26,6 +26,12 @@ models: | |||
| description: "{{ doc('column__offer_type_id') }}" | |||
| - name: offer_sub_type_id | |||
| description: "{{ doc('column__offer_sub_type_id') }}" | |||
| - name: offer_isbn | |||
| description: "{{ doc('column__isbn') }}" | |||
vbusson-pass
force-pushed
the
master
branch
2 times, most recently
from
174fb91 to
a57b4fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DA PR
Describe your changes
Please include a summary of the changes:
Type of change
Checklist before requesting a review
PR title format (except for MEP)
There is a linter on the PR title format. Please respect the following format:
(ticket) type(topic): comment
ticket surrounded by parenthesis, with optionnaly a hyphen followed by one or more digits (e.g., -1234). The first part must be one of the following strings:
type :
The second part to specify the type of change one of the following :
topic within parenthesis: 1 word e.g., (dag)
comment: tell us your life
examples: