Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(DE-650) refactor(linkage): update DAG configuration parameters #3544

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dcuesta-pass
Copy link
Collaborator

This commit updates the DAG configuration parameters in the link_items.py file. The input_sources_table, input_candidates_table, and linked_items_table parameters have been modified to use the values from the DAG_CONFIG dictionary.

PR template

Select PR template in preview mode

PR title format (except for MEP)

There is a linter on the PR title format. Please respect the following format:

(ticket) type(topic): comment
  • ticket surrounded by parenthesis, with optionnaly a hyphen followed by one or more digits (e.g., -1234). The first part must be one of the following strings:

    • DA
    • DE
    • AE
    • DS
    • HF
    • BSR
    • PC
  • type :
    The second part to specify the type of change one of the following :

    • build
    • lint
    • ci
    • docs
    • feat
    • fix
    • perf
    • refactor
    • test
    • core
    • dbt
  • topic within parenthesis: 1 word e.g., (dag)

  • comment: tell us your life

examples:

  • ✅ (DE-124) refactor(firebase): update source field
  • ❌ (DE-124) refactor (firebase): update source field (space between type and topic)
  • ❌ (DE-124) airflow(firebase): update source fiedd in DAG (wrong type)
  • ❌ (DE-124) (DE-124) refactor(firebase refacto): update source field (topic in two words)
  • ✅ (BSR) docs(github): add PR title valid format in template

This commit updates the DAG configuration parameters in the `link_items.py` file. The `input_sources_table`, `input_candidates_table`, and `linked_items_table` parameters have been modified to use the values from the `DAG_CONFIG` dictionary.
Copy link

sonarqubecloud bot commented Dec 2, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant