Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(DE-598) feat(dbt): load backend sources as snapshots #3241

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

LucileRainteau
Copy link
Collaborator

DE PR

Describe your changes

Please include a summary of the changes:

This PR [adds/removes/fixes/replaces] the [feature/bug/etc].

Tag a reviewer if necessacy @github/username

Jira ticket number and/or notion link

JIRA-ticket_number

Type of change

  • Fix (non-breaking change which corrects expected behavior)
  • New fields (non-breaking change)
  • New table (non-breaking change)
  • Concept change (potentially breaking change which modifies fields according to new or evolving business concepts)
  • Table deletion (potentially breaking change which adds functionality/ table)

Checklist before requesting a review

  • I have performed a self-review of my code
  • My code passes CI/CD tests
  • I updated README.md
  • I have updated the dag
  • If my changes concern incremental table, I have altered their schema to accomodate with field's creation/deletion
  • I have made corresponding changes to the tables documentation
  • I have made corresponding changes to the fields glossary
  • I will create a review on slack and ensure to specify the duration of the review task: short (<10min), medium (<30min), long (>30min)

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • ⏰ no, but I created a ticket


SELECT *
FROM EXTERNAL_QUERY("{{ env_var('APPLICATIVE_EXTERNAL_CONNECTION_ID') }}",
'''SELECT
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

t'as essayé sans les ""
et sinon set la variable en début de model:
{% conn_id = env_var('APPLICATIVE_EXTERNAL_CONNECTION_ID')%}

@valoumiaou valoumiaou force-pushed the DE-598-load-backend-sources-as-snapsho branch from e16a7a3 to b3eefe1 Compare October 7, 2024 08:51
@valoumiaou valoumiaou force-pushed the DE-598-load-backend-sources-as-snapsho branch 3 times, most recently from c7f2d7c to 8d0a197 Compare October 7, 2024 10:32
@valoumiaou valoumiaou force-pushed the DE-598-load-backend-sources-as-snapsho branch from 8d0a197 to 7a9549a Compare October 7, 2024 10:45
@valoumiaou valoumiaou force-pushed the DE-598-load-backend-sources-as-snapsho branch from 7a9549a to ac4f38e Compare October 7, 2024 10:48
@LucileRainteau LucileRainteau changed the title (DE-598) load backend sources as snapshots (DE-598) feat: load backend sources as snapshots Oct 7, 2024
@LucileRainteau LucileRainteau changed the title (DE-598) feat: load backend sources as snapshots (DE-598) feat(dbt) load backend sources as snapshots Oct 7, 2024
@LucileRainteau LucileRainteau changed the title (DE-598) feat(dbt) load backend sources as snapshots (DE-598) feat(dbt): load backend sources as snapshots Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants