Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launch vm easyinstall #3231

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Launch vm easyinstall #3231

wants to merge 4 commits into from

Conversation

valoumiaou
Copy link
Collaborator

DE PR

Describe your changes

Please include a summary of the changes:

This PR [adds/removes/fixes/replaces] the [feature/bug/etc].

Tag a reviewer if necessacy @github/username

Jira ticket number and/or notion link

JIRA-ticket_number

Type of change

  • Fix (non-breaking change which corrects expected behavior)
  • New fields (non-breaking change)
  • New table (non-breaking change)
  • Concept change (potentially breaking change which modifies fields according to new or evolving business concepts)
  • Table deletion (potentially breaking change which adds functionality/ table)

Checklist before requesting a review

  • I have performed a self-review of my code
  • My code passes CI/CD tests
  • I updated README.md
  • I have updated the dag
  • If my changes concern incremental table, I have altered their schema to accomodate with field's creation/deletion
  • I have made corresponding changes to the tables documentation
  • I have made corresponding changes to the fields glossary
  • I will create a review on slack and ensure to specify the duration of the review task: short (<10min), medium (<30min), long (>30min)

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • ⏰ no, but I created a ticket

@valoumiaou valoumiaou marked this pull request as draft October 3, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant