Skip to content

Expands parser/lexer tests to test future possible keywords #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2022

Conversation

johnedquinn
Copy link
Member

Relevant Issues

Description

  • Adds tests to assert that the current identifiers of acyclic, both, domain, public', user, leading, trail, and trailing` are lexed and parsed as identifiers.
  • Specifically adds more comprehensive testing to the preprocessor to add testing related to the use of the trim specification keywords.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Base: 86.28% // Head: 86.47% // Increases project coverage by +0.19% 🎉

Coverage data is based on head (43e57f3) compared to base (a279276).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #223      +/-   ##
==========================================
+ Coverage   86.28%   86.47%   +0.19%     
==========================================
  Files          31       31              
  Lines        5074     5146      +72     
==========================================
+ Hits         4378     4450      +72     
  Misses        696      696              
Impacted Files Coverage Δ
partiql-parser/src/lexer.rs 98.35% <100.00%> (+0.09%) ⬆️
partiql-parser/src/parse/mod.rs 95.15% <100.00%> (+0.31%) ⬆️
partiql-parser/src/preprocessor.rs 93.11% <100.00%> (+0.27%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@johnedquinn johnedquinn requested a review from jpschorr November 18, 2022 20:27
@johnedquinn johnedquinn marked this pull request as ready for review November 18, 2022 20:27
@github-actions
Copy link

Conformance comparison report

main (a279276) b1b2505 +/-
% Passing 12.65% 12.65% 0.00%
✅ Passing 349 349 0
❌ Failing 0 0 0
🔶 Ignored 2410 2410 0
Total Tests 2759 2759 0

Number passing in both: 349

Number failing in both: 0

Number passing in main but now fail: 0

Number failing in main but now pass: 0

@johnedquinn johnedquinn merged commit 68ed827 into main Nov 21, 2022
@johnedquinn johnedquinn deleted the non-reserved-tests branch November 21, 2022 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants