Removes SEXP, SYMBOL, and DECIMAL_ARBITRARY from PType and Datum #1633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnedquinn
force-pushed
the
v1-remove-ion
branch
5 times, most recently
from
a6b7dd8
to
6d5cb42
Compare
alancai98
reviewed
Nov 15, 2024
partiql-eval/src/main/kotlin/org/partiql/eval/internal/operator/rel/RelOpExclude.kt
Outdated
Show resolved
Hide resolved
partiql-spi/src/main/kotlin/org/partiql/value/io/PartiQLValueIonReader.kt
Show resolved
Hide resolved
partiql-spi/src/main/kotlin/org/partiql/value/PartiQLValueType.kt
Outdated
Show resolved
Hide resolved
| @@ -89,8 +89,8 @@ internal val Fn_PLUS__DECIMAL_ARBITRARY_DECIMAL_ARBITRARY__DECIMAL_ARBITRARY = F | |||
| name = "plus", | |||
| returns = PType.decimal(), | |||
| parameters = arrayOf( | |||
| @Suppress("DEPRECATION") Parameter("lhs", PType.decimal()), | |||
| @Suppress("DEPRECATION") Parameter("rhs", PType.decimal()), | |||
| Parameter("lhs", PType.decimal()), | |||
There was a problem hiding this comment.
FN name var for above uses DECIMAL_ARBITRARY, perhaps needs to get changed?
There was a problem hiding this comment.
Eventually, yes. Currently rewriting all of the functions. See #1647
| @@ -88,8 +88,8 @@ internal val Fn_LTE__DECIMAL_ARBITRARY_DECIMAL_ARBITRARY__BOOL = Function.static | |||
| name = "lte", | |||
| returns = PType.bool(), | |||
| parameters = arrayOf( | |||
| @Suppress("DEPRECATION") Parameter("lhs", PType.decimal()), | |||
| @Suppress("DEPRECATION") Parameter("rhs", PType.decimal()), | |||
| Parameter("lhs", PType.decimal()), | |||
There was a problem hiding this comment.
Similarly, fn name variable uses DECIMAL_ARB. Perhaps should get changed?
Also applies for
- lt
- gt
- gte
- between
- may have some others, so probably need to do a check on Builtins.kt
| name = "concat", | ||
| returns = PType.string(), | ||
| returns = PType.character(256), // TODO: Handle length |
There was a problem hiding this comment.
Should these TODOs for length be handled in this PR or tracked somewhere else?
There was a problem hiding this comment.
The work for this has begun in #1647.
Comment on lines
+39
to
+58
| PType.time(6), // TODO: Precision | ||
| PType.timez(6), // TODO: Precision | ||
| ) | ||
|
|
||
| val allTimeStampPType = setOf( | ||
| PType.timestamp(6), // TODO: Precision | ||
| PType.timestampz(6), // TODO: Precision | ||
| ) | ||
|
|
||
| val allDateTimePType = allDatePType + allTimePType + allTimeStampPType | ||
|
|
||
| val allCharStringPType = setOf( | ||
| PType.character(256), // TODO: Length | ||
| PType.varchar(256), // TODO: Length | ||
| PType.string(), | ||
| PType.clob(Int.MAX_VALUE), // TODO: Length | ||
| ) | ||
|
|
||
| val allBinaryPType = setOf( | ||
| PType.blob(Int.MAX_VALUE), // TODO: Length |
There was a problem hiding this comment.
Will these TODOs for precision/length be addressed in this PR or are they tracked in some other issue?
Adds error for DECIMAL_ARBITRARY usage
johnedquinn
force-pushed
the
v1-remove-ion
branch
from
ce66d34
to
d9715e4
Compare
alancai98
approved these changes
Nov 18, 2024
johnedquinn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing
Follow-ups
License Information
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.