Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gen 3] stack size fixes, __cxa_acquire/release/atexit refactoring #2851

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

avtolstoy
Copy link
Member

Problem

Gen 3 platforms trigger a hardfault on boot with #2840 every other time.

Solution

  1. Increase main stack size for Gen 3 platforms from 2K to 4K
  2. Add asserts to linker files to make sure that stack sizes match the expected values
  3. atexit is not needed for our platforms, so it's now stubbed out freeing additional flash space of unneccassary destructor implementations
  4. __cxa_acquire/__cxa_release do not account for thread-safety, the implementation has been refactored.
  5. Panic handler should not log anything, as that may trigger a secondary fault making debugging more difficult and causing a lock-up instead of a reset

Steps to Test

#2840 cloud test app

Example App

N/A

References

N/A


Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

@avtolstoy avtolstoy added the bug label Dec 30, 2024
@avtolstoy avtolstoy added this to the 6.3.0 milestone Dec 30, 2024
@avtolstoy avtolstoy requested a review from sergeuz December 30, 2024 19:36
Copy link
Member

@sergeuz sergeuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants