ci: Fix eslint config #9723
ci: Fix eslint config #9723
Conversation
|
🚀 Thanks for opening this pull request! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## alpha #9723 +/- ##
==========================================
- Coverage 93.01% 92.98% -0.04%
==========================================
Files 187 187
Lines 15081 15112 +31
Branches 174 174
==========================================
+ Hits 14028 14052 +24
- Misses 1041 1048 +7
Partials 12 12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| it_id('23caddd7-bfea-4869-8bd4-0f2cd283c8bd')(it)( | ||
| 'can start Parse Server with auth via CLI', | ||
| done => { |
There was a problem hiding this comment.
What line length is this enforcing? Looks less readable to me this way.
There was a problem hiding this comment.
Looks like prettier has a 100 line length
There was a problem hiding this comment.
Should we set this to longer lines, like 170?
There was a problem hiding this comment.
We could but it’s up to you to review 170+ files being changed. My plan was to remove prettier and husky anyway like the JS SDK. Should I just redo this PR without running prettier?
There was a problem hiding this comment.
Should I just redo this PR without running prettier?
I think that would be good; we may consider running a reformat across all files in a dedicated PR, if it's worth it. It's just such a large change that I'm afraid it would create merge conflicts or complicated rebases across pending PRs. Maybe we can do this if we get to a point where we clean up the PR list.
📝 WalkthroughWalkthroughThis update is primarily a large-scale codebase cleanup focused on stylistic and formatting consistency. The changes include expanding single-line conditional statements into multi-line blocks with braces, reformatting function signatures, improving indentation, and restructuring object literals and function calls for better readability. ESLint directive comments disabling console usage are removed throughout, and the ESLint configuration is updated to disable the Changes
Sequence Diagram(s)sequenceDiagram
participant Developer
participant Linter
participant TestSuite
Developer->>Linter: Run ESLint (with updated config)
Linter-->>Developer: No warnings for console statements
Developer->>TestSuite: Run tests (with reformatted code)
TestSuite-->>Developer: Test results (logic unchanged)
Developer->>TestSuite: Run new/updated test for unique index
TestSuite-->>Developer: Verifies unique index enforcement
sequenceDiagram
participant User
participant ParseServer
participant Database
User->>ParseServer: Save object with unique field
ParseServer->>Database: Attempt to save/update
Database-->>ParseServer: Enforces unique index
ParseServer-->>User: Error if duplicate, success otherwise
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ast-grep (0.31.1)spec/AuthenticationAdaptersV2.spec.jsspec/ParseQuery.spec.jsspec/ParseUser.spec.js
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Pull Request
Issue
Eslint is broken, runs prettier
Summary by CodeRabbit
Style
Chores
Bug Fixes
Tests
No changes to user-facing features or functionality.