Skip to content

feat: Add Firebase Cloud Messaging (FCM) HTTP/2 support and option fcmEnableLegacyHttpTransport to use legacy HTTP/1.1 #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Aug 2, 2024
Merged

feat: Add Firebase Cloud Messaging (FCM) HTTP/2 support and option fcmEnableLegacyHttpTransport to use legacy HTTP/1.1 #274

merged 10 commits into from
Aug 2, 2024

Conversation

jimnor0xF
Copy link
Contributor

@jimnor0xF jimnor0xF commented Jul 31, 2024 •
edited
Loading

New Pull Request Checklist

Issue Description

firebase-admin recently added support to this in the release of v12.3.0.

Closes: #251

Approach

  • Bump version to v12.3.0.
  • Provide new flag in push options for FCM to enable legacy HTTP transport if wanted.

Tested and working.

@parse-github-assistant Parse GitHub Assistant
Copy link

parse-github-assistant bot commented Jul 31, 2024 •
edited
Loading

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

mtrezza
mtrezza reviewed Aug 1, 2024
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've restructured the docs a bit, since FCM sections apply to both apple and android push configs (if using FCM for both). Could you please check whether it makes sense?

Could you please add a test that checks whether setting the new option is properly sent to the adapter? for true, false, and the default value.

@jimnor0xF
Copy link
Contributor Author

I've restructured the docs a bit, since FCM sections apply to both apple and android push configs (if using FCM for both). Could you please check whether it makes sense?

Could you please add a test that checks whether setting the new option is properly sent to the adapter? for true, false, and the default value.

It looks good to me. Sure, I'll add a test in.

@mtrezza mtrezza changed the title feat: Add FCM http2 support feat: Add Firebase Cloud Messaging (FCM) HTTP/2 support and option fcmEnableLegacyHttpTransport to use legacy HTTP/1.1 Aug 2, 2024
@mtrezza mtrezza merged commit 70e6b6f into parse-community:master Aug 2, 2024
6 checks passed
parseplatformorg pushed a commit that referenced this pull request Aug 2, 2024
@semantic-release-bot
chore(release): 6.5.0 [skip ci]
6e845ac 
# [6.5.0](6.4.1...6.5.0) (2024-08-02)

### Features

* Add Firebase Cloud Messaging (FCM) HTTP/2 support and option `fcmEnableLegacyHttpTransport` to use legacy HTTP/1.1 ([#274](#274)) ([70e6b6f](70e6b6f))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.5.0

mtrezza
mtrezza reviewed Aug 2, 2024
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, just made a minor change related to test stability

@jimnor0xF jimnor0xF deleted the http2_support_251 branch August 4, 2024 11:32
@parseplatformorg parseplatformorg mentioned this pull request Nov 9, 2024
Closed
@mtrezza mtrezza mentioned this pull request Dec 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtrezza mtrezza mtrezza left review comments

Assignees
No one assigned
Labels
state:released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for FCM http2 API
3 participants
@jimnor0xF @parseplatformorg @mtrezza