fix: Data browser does not cancel obsolete long-loading request on sorting field change #2839

dblythy · 2025-06-01T09:25:04Z

New Pull Request Checklist

I am not disclosing a vulnerability.
I am creating this PR in reference to an issue.

Issue Description

Closes: #2820

Approach

TODOs before merging

Summary by CodeRabbit

Bug Fixes
- Improved data loading reliability by ensuring that only one data request is active at a time and cancelling any ongoing requests when navigating away from the data browser. This prevents potential issues with overlapping or stale data.

parse-github-assistant · 2025-06-01T09:25:08Z

🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review.

coderabbitai · 2025-06-01T09:25:11Z

📝 Walkthrough

"""

Walkthrough

The changes add logic to the Browser component to track and cancel ongoing Parse queries. An instance variable currentQuery is introduced to store the active query. Before starting a new query or when the component unmounts, any existing query is canceled to prevent overlapping or stale data requests.

Changes

File(s)	Change Summary
src/dashboard/Data/Browser/Browser.react.js	Added `currentQuery` instance variable; cancel previous query before new fetch; cancel on unmount

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant BrowserComponent
    participant ParseQuery

    User->>BrowserComponent: Initiates data fetch (e.g., sorts column)
    alt Existing currentQuery
        BrowserComponent->>ParseQuery: Cancel currentQuery
    end
    BrowserComponent->>ParseQuery: Create new query
    BrowserComponent->>ParseQuery: Assign to currentQuery
    ParseQuery-->>BrowserComponent: Return results

    Note over BrowserComponent: On unmount
    alt currentQuery exists
        BrowserComponent->>ParseQuery: Cancel currentQuery
    end

Assessment against linked issues

Objective	Addressed	Explanation
Cancel obsolete long-loading request on sorting field change (#2820)	✅
Ensure only the result of the latest query is displayed in the data browser (#2820)	✅
Cancel HTTP request if possible when query is obsolete (#2820)	✅

Assessment against linked issues: Out-of-scope changes

No out-of-scope changes were found.
"""

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

npm error code ERR_SSL_WRONG_VERSION_NUMBER
npm error errno ERR_SSL_WRONG_VERSION_NUMBER
npm error request to https://10.0.0.28:4873/npm/-/npm-10.9.2.tgz failed, reason: C0AC17E1FC7E0000:error:0A00010B:SSL routines:ssl3_get_record:wrong version number:../deps/openssl/openssl/ssl/record/ssl3_record.c:354:
npm error
npm error A complete log of this run can be found in: /.npm/_logs/2025-06-01T09_29_26_141Z-debug-0.log

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d28b04b and 7f6d7bc.

📒 Files selected for processing (1)

src/dashboard/Data/Browser/Browser.react.js (4 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

src/dashboard/Data/Browser/Browser.react.js

⏰ Context from checks skipped due to timeout of 90000ms (1)

GitHub Check: Docker linux/amd64

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

parseplatformorg · 2025-06-01T09:25:16Z

🎉 Snyk checks have passed. No issues have been found so far.

✅ security/snyk check is complete. No issues have been found. (View Details)

mtrezza

@dblythy Is this ready for merge?

dblythy · 2025-06-02T09:09:17Z

Yep 😊

## [7.2.1-alpha.1](7.2.0...7.2.1-alpha.1) (2025-06-02) ### Bug Fixes * Data browser does not cancel obsolete long-loading request on sorting field change ([#2839](#2839)) ([0f85376](0f85376))

parseplatformorg · 2025-06-02T09:39:35Z

🎉 This change has been released in version 7.2.1-alpha.1

Update Browser.react.js

d28b04b

Update Browser.react.js

7f6d7bc

coderabbitai bot approved these changes Jun 1, 2025

View reviewed changes

Merge branch 'alpha' into feature/cancel-requests

2e13e58

mtrezza changed the title ~~feature: cancel old requests~~ fix: Data browser does not cancel obsolete long-loading request on sorting field change Jun 1, 2025

mtrezza approved these changes Jun 2, 2025

View reviewed changes

mtrezza merged commit 0f85376 into parse-community:alpha Jun 2, 2025
9 of 11 checks passed

parseplatformorg added the state:released-alpha Released as alpha version label Jun 2, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix: Data browser does not cancel obsolete long-loading request on sorting field change #2839

fix: Data browser does not cancel obsolete long-loading request on sorting field change #2839

Uh oh!

dblythy commented Jun 1, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

parse-github-assistant bot commented Jun 1, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Jun 1, 2025 •

edited

Loading

Walkthrough

Changes

Sequence Diagram(s)

Assessment against linked issues

Assessment against linked issues: Out-of-scope changes

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

parseplatformorg commented Jun 1, 2025 •

edited

Loading

Uh oh!

mtrezza left a comment

Uh oh!

dblythy commented Jun 2, 2025

Uh oh!

Uh oh!

parseplatformorg commented Jun 2, 2025

Uh oh!

Uh oh!

Uh oh!

fix: Data browser does not cancel obsolete long-loading request on sorting field change #2839

fix: Data browser does not cancel obsolete long-loading request on sorting field change #2839

Uh oh!

Conversation

dblythy commented Jun 1, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

New Pull Request Checklist

Issue Description

Approach

TODOs before merging

Summary by CodeRabbit

Uh oh!

parse-github-assistant bot commented Jun 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Jun 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Assessment against linked issues

Assessment against linked issues: Out-of-scope changes

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

parseplatformorg commented Jun 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎉 Snyk checks have passed. No issues have been found so far.

Uh oh!

mtrezza left a comment

Choose a reason for hiding this comment

Uh oh!

dblythy commented Jun 2, 2025

Uh oh!

Uh oh!

parseplatformorg commented Jun 2, 2025

Uh oh!

Uh oh!

dblythy commented Jun 1, 2025 •

edited by coderabbitai bot

Loading

parse-github-assistant bot commented Jun 1, 2025 •

edited

Loading

coderabbitai bot commented Jun 1, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

parseplatformorg commented Jun 1, 2025 •

edited

Loading