-
-
Notifications
You must be signed in to change notification settings - Fork 69
feat: add ParseObjectMutable protocol #270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I will reformat the title to use the proper commit message syntax. |
Thanks for opening this pull request!
|
Codecov Report
@@ Coverage Diff @@
## main #270 +/- ##
==========================================
- Coverage 82.34% 82.33% -0.01%
==========================================
Files 99 100 +1
Lines 10512 10518 +6
==========================================
+ Hits 8656 8660 +4
- Misses 1856 1858 +2
Continue to review full report at Codecov.
|
In order to properly make sure this runs through the CI, you will need to replace empty object in the test suite here
with the protocol you added. In that file, you will need to switch emptyObject to the new property name in the protocol for the emptyObject tests. Since this protocol is optional and something the developer choses to add themselves. There wouldn't be much else that needs to be added to the SDK besides cleaning up the documentation. With this said, I think you can add all of this now which will allow us to asses the feasibility and simplicity (the test suite). In theory it should work as the |
I will reformat the title to use the proper commit message syntax. |
ParseSwift.playground/Pages/6 - Installation.xcplaygroundpage/Contents.swift
Outdated
Show resolved
Hide resolved
ParseSwift.playground/Pages/4 - User - Continued.xcplaygroundpage/Contents.swift
Outdated
Show resolved
Hide resolved
ParseSwift.playground/Pages/15 - Custom ObjectId.xcplaygroundpage/Contents.swift
Show resolved
Hide resolved
You will need to |
It's looking good, just a for more nits! |
click the |
LGTM! |
New Pull Request Checklist
Issue Description
Related issue: #269
Approach
Make emptyObject more developer friendly.
TODOs before merging
Notes
Before I put more work into this, @cbaker6 - @dblythy what's your opinion about this approach?