Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add vite #2425

Open
wants to merge 19 commits into
base: alpha
Choose a base branch
from
Open

feat: Add vite #2425

wants to merge 19 commits into from

Conversation

dblythy
Copy link
Member

@dblythy dblythy commented Feb 2, 2025

Pull Request

Issue

Closes: #2410

Approach

Vite is more modern than webpack, so approaching building files with vite. Testing will still be needed

Tasks

  • Add tests
  • Add changes to documentation (guides, repository pages, code comments)

Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title feat: add vite feat: Add vite Feb 2, 2025
Copy link

Thanks for opening this pull request!

@dplewis
Copy link
Member

dplewis commented Feb 7, 2025

Nice! Need some help? I'm interested in seeing how this would work with tree shaking.

@dblythy
Copy link
Member Author

dblythy commented Feb 9, 2025

@dplewis I think the challenge here is that Vite might/webpack not be compatible with CJS. Any thoughts?

@dplewis dplewis mentioned this pull request Feb 9, 2025
2 tasks
@dplewis
Copy link
Member

dplewis commented Feb 9, 2025

I’m not familiar with vite but I see you have a umd bundle in your output, you should be able to output cjs. By compatibility are you referring to the input as cjs? We can change that

@dblythy
Copy link
Member Author

dblythy commented Feb 19, 2025

Just having some issues getting some of the browser apis (crypto etc) to polyfill to node. seems to be coming along well though

Copy link

codecov bot commented Feb 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (a021d20) to head (fce0d67).

Additional details and impacted files
@@            Coverage Diff            @@
##             alpha     #2425   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           64        64           
  Lines         6256      6232   -24     
  Branches      1476      1477    +1     
=========================================
- Hits          6256      6232   -24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace browserify with webpack
2 participants