FLPATH-274 enable spring-cloud-config #225
Conversation
| springdoc: | ||
| writer-with-order-by-keys: true | ||
| writer-with-default-pretty-printer: true |
There was a problem hiding this comment.
These are necessary to properly generate SDK files. Why do you delete them?
There was a problem hiding this comment.
These properties are redundant, they are in application.yml so for local profile it will be inherited from the https://github.com/parodos-dev/parodos/blob/main/notification-service/src/main/resources/application.yml
|
The change looks good to me, please rebase |
|
/lgtm |
|
rebased, please review again. |
| @@ -24,7 +24,7 @@ public void testGetHash() { | |||
| // when | |||
| assertDoesNotThrow(() -> { | |||
| String hash = this.workFlowVersionService.getHash(object); | |||
| assertEquals(hash, "b0c8ed039dc102c0bab6a5e979931a0b"); | |||
| assertEquals(hash, "3ffe85fac846ce265bcef0534e6334b7"); | |||
There was a problem hiding this comment.
This change won't be needed after #239
|
@sergiubodiu since the target deployment of parodos is k8s/openshift, what changes will be required to support configmap and secret as configuration resources of the application? |
|
Needs approve label to be merged. @masayag it doesn't require changes on parodos as we're consumer of the configuration. Spring-Cloud-Kubernetes config server is a server side change. Parodos being a client will consume those secrets / config maps and inject it into the variables that we define. I created a demo server https://github.com/sergiubodiu/parodos-configserver However if we want to configure dynamic Kubernetes clients we could look into Fabric8 or the next gen https://github.com/eclipse/jkube both have a lot of red hat contributors |
Should the config-server be distributed as part of parodos deployment or is the expectation for a user to have its own config-server? My question is, should we move the parodos-configserver project into parodos organization and use it in our tests when deployed on top of k8s?
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: masayag The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@sergiubodiu please rebase and we will merge. All labels are added |
I've enabled it for local development where the configserver can be passed through variable or located at default location localhost:8888
For testing purposes created demo config server https://github.com/sergiubodiu/parodos-configserver with configurations copied from local development
https://github.com/sergiubodiu/parodos-config-repo