deps: remove polkadot-sdk umbrella crate #1926
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasad1
changed the title
niklasad1
commented
Feb 20, 2025
niklasad1
commented
Feb 20, 2025
jsdw
approved these changes
Feb 20, 2025
lexnv
approved these changes
Feb 21, 2025
niklasad1
commented
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1925
Basically for library users of subxt
cargocan't figure out which features are enabled and ends up fetching all cratesfrom the polkadot-sdk umbrella which is annoying.
Since we are using quite few of the dependencies from polkadot-sdk anyway the umbrella crate doesn't help that much, so let's get rid of it again.
I liked the idea with the umbrella crate for maintainability for subxt but not worth it.