Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove substrate compat #1850

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

remove substrate compat #1850

wants to merge 14 commits into from

Conversation

niklasad1
Copy link
Member

@niklasad1 niklasad1 commented Oct 30, 2024

Close #1847

@niklasad1 niklasad1 changed the title WIP: remove substrate compat remove substrate compat Nov 4, 2024
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just repeating what I already said on the call: I'd either:

  1. Remove this example, or
  2. Show in the fn main() for it something that demonstrates when this approach is good to take (ie when would I copy this example versus copying the simpler substrate_compat_signer one which ultimately runs the same code)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this example; for me it shows that it's not hard to use Substrate's signer stuff instead if people would rather do that!

Copy link
Collaborator

@jsdw jsdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the signer example I feel happy enough removing the substrate compat feature; it's not too hard plugging things like Substrate's signer stuff in, and this means we are independent and one can write SUbxt code against any version of polkadot-sdk that they want :)

@niklasad1 niklasad1 marked this pull request as ready for review November 13, 2024 09:37
@niklasad1 niklasad1 requested a review from a team as a code owner November 13, 2024 09:37
@jsdw
Copy link
Collaborator

jsdw commented Nov 13, 2024

Whoops; my suggestion broke the cargo check; I forgot about the extra import needed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove substrate-compat feature
2 participants