remove substrate compat #1850
Open
remove substrate compat #1850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsdw
reviewed
Nov 12, 2024
jsdw
reviewed
Nov 12, 2024
subxt/examples/substrate_compat.rs
Outdated
There was a problem hiding this comment.
Just repeating what I already said on the call: I'd either:
- Remove this example, or
- Show in the
fn main()for it something that demonstrates when this approach is good to take (ie when would I copy this example versus copying the simplersubstrate_compat_signerone which ultimately runs the same code)
jsdw
reviewed
Nov 12, 2024
There was a problem hiding this comment.
I like this example; for me it shows that it's not hard to use Substrate's signer stuff instead if people would rather do that!
jsdw
reviewed
Nov 12, 2024
There was a problem hiding this comment.
Based on the signer example I feel happy enough removing the substrate compat feature; it's not too hard plugging things like Substrate's signer stuff in, and this means we are independent and one can write SUbxt code against any version of polkadot-sdk that they want :)
|
Whoops; my suggestion broke the cargo check; I forgot about the extra import needed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1847